[GitHub] [zookeeper] symat commented on a change in pull request #1498: ZOOKEEPER-2649 - Add more session and authentication information to S…

[GitBox <gi...@apache.org>]

symat commented on a change in pull request #1498:
URL: https://github.com/apache/zookeeper/pull/1498#discussion_r507805695



##########
File path: zookeeper-server/src/main/java/org/apache/zookeeper/server/ZooKeeperServer.java
##########
@@ -1599,8 +1599,11 @@ public void processPacket(ServerCnxn cnxn, ByteBuffer incomingBuffer) throws IOE
                 }
             }
             if (authReturn == KeeperException.Code.OK) {
+                ZooKeeperSaslServer saslServer = cnxn.zooKeeperSaslServer;
                 LOG.debug("Authentication succeeded for scheme: {}", scheme);
-                LOG.info("auth success {}", cnxn.getRemoteSocketAddress());
+                LOG.info("Session 0x{}: auth success for authorizationID={}/{}",
+                        Long.toHexString(cnxn.getSessionId()), saslServer.getAuthorizationID(),
+                        cnxn.getRemoteSocketAddress());

Review comment:
       > In conclusion: I'd just add the sessionId and scheme there, and ignore the actual Id(s).
   
   make sense to me.
   (for SASL I think we already have log outputs about the authenticated principal names)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org