You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by cui dt <cu...@outlook.com> on 2018/06/12 19:19:14 UTC
Review Request 67557: Add contributor info at the file
contributors.yaml.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/
-----------------------------------------------------------
Review request for mesos and Gilbert Song.
Repository: mesos
Description
-------
Add contributor info at the file contributors.yaml.
Diffs
-----
docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
Diff: https://reviews.apache.org/r/67557/diff/1/
Testing
-------
Thanks,
cui dt
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204701
-----------------------------------------------------------
docs/contributors.yaml
Lines 758 (patched)
<https://reviews.apache.org/r/67557/#comment287343>
Would you mind putting your full name here (just like all the others)?
- Gilbert Song
On June 12, 2018, 1:24 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 1:24 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add contributor info at the contributors.yaml.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by Mesos Reviewbot Windows <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204653
-----------------------------------------------------------
PASS: Mesos patch 67557 was successfully built and tested.
Reviews applied: `['67557']`
All the build artifacts available at: http://dcos-win.westus.cloudapp.azure.com/mesos-build/review/67557
- Mesos Reviewbot Windows
On June 12, 2018, 8:24 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 8:24 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add contributor info at the contributors.yaml.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by cui dt <cu...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204642
-----------------------------------------------------------
Ship it!
Ship It!
- cui dt
On 六月 12, 2018, 8:24 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> -----------------------------------------------------------
>
> (Updated 六月 12, 2018, 8:24 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add contributor info at the contributors.yaml.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by cui dt <cu...@outlook.com>.
> On 六月 13, 2018, 4:41 p.m., Gilbert Song wrote:
> > also, please use this commit message: "Added <your name> to the contributor list."
OK,I have changed,please review .
- cui
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204702
-----------------------------------------------------------
On 六月 13, 2018, 8:05 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> -----------------------------------------------------------
>
> (Updated 六月 13, 2018, 8:05 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added DaoTan Cui to the contributor list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204702
-----------------------------------------------------------
also, please use this commit message: "Added <your name> to the contributor list."
- Gilbert Song
On June 12, 2018, 1:24 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> -----------------------------------------------------------
>
> (Updated June 12, 2018, 1:24 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Add contributor info at the contributors.yaml.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by Mesos Reviewbot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204760
-----------------------------------------------------------
Patch looks great!
Reviews applied: [67557]
Passed command: export OS='ubuntu:14.04' BUILDTOOL='autotools' COMPILER='gcc' CONFIGURATION='--verbose --disable-libtool-wrappers' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker-build.sh
- Mesos Reviewbot
On June 13, 2018, 8:05 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 8:05 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added DaoTan Cui to the contributor list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by Gilbert Song <so...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/#review204807
-----------------------------------------------------------
docs/contributors.yaml
Lines 758 (patched)
<https://reviews.apache.org/r/67557/#comment287539>
could we add your last name?
or I missed something?
- Gilbert Song
On June 13, 2018, 1:05 p.m., cui dt wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/67557/
> -----------------------------------------------------------
>
> (Updated June 13, 2018, 1:05 p.m.)
>
>
> Review request for mesos and Gilbert Song.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> Added DaoTan Cui to the contributor list.
>
>
> Diffs
> -----
>
> docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
>
>
> Diff: https://reviews.apache.org/r/67557/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> cui dt
>
>
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by cui dt <cu...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/
-----------------------------------------------------------
(Updated 六月 13, 2018, 8:05 p.m.)
Review request for mesos and Gilbert Song.
Repository: mesos
Description (updated)
-------
Added DaoTan Cui to the contributor list.
Diffs
-----
docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
Diff: https://reviews.apache.org/r/67557/diff/1/
Testing
-------
Thanks,
cui dt
Re: Review Request 67557: Add contributor info at the file
contributors.yaml.
Posted by cui dt <cu...@outlook.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/67557/
-----------------------------------------------------------
(Updated 六月 12, 2018, 8:24 p.m.)
Review request for mesos and Gilbert Song.
Repository: mesos
Description (updated)
-------
Add contributor info at the contributors.yaml.
Diffs
-----
docs/contributors.yaml 64f040aed29ebd573a1d10a4d9191b3391924958
Diff: https://reviews.apache.org/r/67557/diff/1/
Testing
-------
Thanks,
cui dt