You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@netbeans.apache.org by mcdonnell-john <gi...@git.apache.org> on 2017/10/11 07:05:09 UTC

[GitHub] incubator-netbeans pull request #118: [NETBEANS-54] Module Review o.eclipse....

GitHub user mcdonnell-john opened a pull request:

    https://github.com/apache/incubator-netbeans/pull/118

    [NETBEANS-54] Module Review o.eclipse.jgit

    Had to change from using a jar called:
    org.eclipse.jgit-3.6.2.201501210735-r-nosignature.jar to
    org.eclipse.jgit-3.6.2.201501210735-r.jar
    Since the previous one wasnt in maven.  NO NOTICE file added - Not sure it needs one since its under EDL - see https://github.com/eclipse/jgit/tree/v3.6.2.201501210735-r

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/mcdonnell-john/incubator-netbeans feature/NETBEANS-54/o.eclipse.jgit

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-netbeans/pull/118.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #118
    
----
commit 0f0a0a51866412902354c2f0d814f318719e235b
Author: John McDonnell <jo...@bearingpoint.com>
Date:   2017-10-11T07:01:23Z

    [NETBEANS-54] Updated binaries to use maven lookups - 
    Had to change from using a jar called:
    org.eclipse.jgit-3.6.2.201501210735-r-nosignature.jar to
    org.eclipse.jgit-3.6.2.201501210735-r.jar
    Since the previous one wasnt in maven.  NO NOTICE file added - Not sure it needs one since its under EDL - see https://github.com/eclipse/jgit/tree/v3.6.2.201501210735-r

----


---

[GitHub] incubator-netbeans issue #118: [NETBEANS-54] Module Review o.eclipse.jgit

Posted by matthiasblaesing <gi...@git.apache.org>.

Github user matthiasblaesing commented on the issue:

    https://github.com/apache/incubator-netbeans/pull/118
  
    New binaries contain signatures - this might be a problem in the future, if so the build process need to be adjusted to strip the signatures away. Thank you.


---

[GitHub] incubator-netbeans pull request #118: [NETBEANS-54] Module Review o.eclipse....

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/incubator-netbeans/pull/118


---