You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Todd Lipcon (JIRA)" <ji...@apache.org> on 2012/05/17 03:00:29 UTC
[jira] [Updated] (HADOOP-8406)
CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
[ https://issues.apache.org/jira/browse/HADOOP-8406?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Todd Lipcon updated HADOOP-8406:
--------------------------------
Attachment: hadoop-8406.txt
Attached patch synchronizes the iteration over this list.
I didn't add a unit test because it would be nearly impossible to write one that failed reliably, since it only affects the very first call after the class has been classloaded.
> CompressionCodecFactory.CODEC_PROVIDERS iteration is thread-unsafe
> ------------------------------------------------------------------
>
> Key: HADOOP-8406
> URL: https://issues.apache.org/jira/browse/HADOOP-8406
> Project: Hadoop Common
> Issue Type: Bug
> Components: io
> Affects Versions: 2.0.0
> Reporter: Todd Lipcon
> Assignee: Todd Lipcon
> Attachments: hadoop-8406.txt
>
>
> CompressionCodecFactory defines CODEC_PROVIDERS as:
> {code}
> private static final ServiceLoader<CompressionCodec> CODEC_PROVIDERS =
> ServiceLoader.load(CompressionCodec.class);
> {code}
> but this is a lazy collection which is thread-unsafe to iterate. We either need to synchronize when we iterate over it, or we need to materialize it during class-loading time by copying to a non-lazy collection
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira