[GitHub] wohali commented on a change in pull request #1769: Add Credo to Elixir test suite

[GitBox <gi...@apache.org>]

wohali commented on a change in pull request #1769: Add Credo to Elixir test suite
URL: https://github.com/apache/couchdb/pull/1769#discussion_r237211435
 
 

 ##########
 File path: Makefile
 ##########
 @@ -172,14 +172,18 @@ soak-eunit: couch
 	while [ $$? -eq 0 ] ; do $(REBAR) -r eunit $(EUNIT_OPTS) ; done
 
 .PHONY: elixir
-elixir: elixir-check-formatted
+elixir: elixir-check-formatted elixir-credo
 	@rm -rf dev/lib
 	@dev/run -a adm:pass --no-eval test/elixir/run
 
 .PHONY: elixir-check-formatted
 elixir-check-formatted:
 	@cd test/elixir/ && mix format --check-formatted
 
+.PHONY: elixir-credo
 
 Review comment:
   Can you add a comment in the two Makefiles that explains what `credo` actually is? For people unfamiliar with Elixir it may not be clear that this is a linting/formatting tool.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services