You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@lens.apache.org by Jaideep dhok <ja...@inmobi.com> on 2015/02/19 13:53:58 UTC

Review Request 31187: LENS-315 Load database specific jars from configurable location

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/31187/
-----------------------------------------------------------

Review request for lens and Amareshwari Sriramadasu.


Bugs: LENS-315
    https://issues.apache.org/jira/browse/LENS-315


Repository: lens


Description
-------

Changes -
1. Added DatabaseResourceService which loads Db specific jars and maintains DB class loaders
2. HiveSessionService starts DatabaseResourceService
3. Changed LensSessionImpl to set classloader upon DB switch, and to construct class loader using added resources + resources of current DB


Diffs
-----

  lens-server-api/src/main/java/org/apache/lens/server/api/LensConfConstants.java fdfce93f0d5ff8d151ccac4238f75c07b95d115c 
  lens-server/src/main/java/org/apache/lens/server/LensServerConf.java 0f9ac1a3a01d2172c9100349fb74fcf472e6a16e 
  lens-server/src/main/java/org/apache/lens/server/session/DatabaseResourceService.java PRE-CREATION 
  lens-server/src/main/java/org/apache/lens/server/session/HiveSessionService.java 7b365db214fbc85e0d47137e205a17a40f7f5578 
  lens-server/src/main/java/org/apache/lens/server/session/LensSessionImpl.java 68559b723cf080ec6b7f41617f2d243a876a80e1 
  lens-server/src/main/resources/lensserver-default.xml 331448f432141342f4b370ca2f64f1d4a0669372 
  lens-server/src/test/java/org/apache/lens/server/session/TestDatabaseResourceService.java PRE-CREATION 
  lens-server/src/test/java/org/apache/lens/server/session/TestSessionClassLoaders.java PRE-CREATION 
  lens-server/testdata/ClassLoaderTestClass.java PRE-CREATION 
  lens-server/testdata/ClassLoaderTestClass2.java PRE-CREATION 
  lens-server/testdata/test.jar PRE-CREATION 
  lens-server/testdata/test2.jar PRE-CREATION 
  src/site/apt/admin/config.apt 5aaf8e9e6accf2f863b6f9be685c440a99d98b79 

Diff: https://reviews.apache.org/r/31187/diff/


Testing
-------

1. Added unit tests for DatabaseResourceService 
2. New unit tests related to class loading

Running all tests will update test results when done.


Thanks,

Jaideep dhok