You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@doris.apache.org by GitBox <gi...@apache.org> on 2023/01/13 06:37:25 UTC
[GitHub] [doris] dutyu opened a new pull request, #15898: [Enhancement](profile) use queryId of originStatement as the queryId.
dutyu opened a new pull request, #15898:
URL: https://github.com/apache/doris/pull/15898
# Proposed changes
Load profile and export profile use job's id as the queryId field, but it is of no use. We should use the origin statemnet's queryId so we can use conjunctive query to find one query's profile by queryId.
## Problem summary
Describe your changes.
## Checklist(Required)
1. Does it affect the original behavior:
- [ ] Yes
- [x] No
- [ ] I don't know
2. Has unit tests been added:
- [ ] Yes
- [ ] No
- [x] No Need
3. Has document been added or modified:
- [ ] Yes
- [x] No
- [ ] No Need
4. Does it need to update dependencies:
- [ ] Yes
- [x] No
5. Are there any changes that cannot be rolled back:
- [ ] Yes (If Yes, please explain WHY)
- [x] No
## Further comments
If this is a relatively large or complex change, kick off the discussion at [dev@doris.apache.org](mailto:dev@doris.apache.org) by explaining why you chose the solution you did and what alternatives you considered, etc...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] hello-stephen commented on pull request #15898: [Enhancement](profile) use queryId of originStatement as the queryId.
Posted by GitBox <gi...@apache.org>.
hello-stephen commented on PR #15898:
URL: https://github.com/apache/doris/pull/15898#issuecomment-1381605601
TeamCity pipeline, clickbench performance test result:
the sum of best hot time: 36.87 seconds
load time: 518 seconds
storage size: 17122722516 Bytes
https://doris-community-test-1308700295.cos.ap-hongkong.myqcloud.com/tmp/20230113101321_clickbench_pr_79758.html
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] spaces-X merged pull request #15898: [Enhancement](profile) use queryId of originStatement as the queryId.
Posted by GitBox <gi...@apache.org>.
spaces-X merged PR #15898:
URL: https://github.com/apache/doris/pull/15898
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15898: [Enhancement](profile) use queryId of originStatement as the queryId.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15898:
URL: https://github.com/apache/doris/pull/15898#issuecomment-1383106084
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] spaces-X commented on a diff in pull request #15898: [Enhancement](profile) use queryId of originStatement as the queryId.
Posted by GitBox <gi...@apache.org>.
spaces-X commented on code in PR #15898:
URL: https://github.com/apache/doris/pull/15898#discussion_r1070282608
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BulkLoadJob.java:
##########
@@ -97,6 +100,7 @@ public BulkLoadJob(EtlJobType jobType, long dbId, String label,
OriginStatement originStmt, UserIdentity userInfo) throws MetaNotFoundException {
super(jobType, dbId, label);
this.originStmt = originStmt;
+ this.queryId = DebugUtil.printId(ConnectContext.get().queryId());
Review Comment:
please fix NPE in Fe UT
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] dutyu commented on a diff in pull request #15898: [Enhancement](profile) use queryId of originStatement as the queryId.
Posted by GitBox <gi...@apache.org>.
dutyu commented on code in PR #15898:
URL: https://github.com/apache/doris/pull/15898#discussion_r1070532188
##########
fe/fe-core/src/main/java/org/apache/doris/load/loadv2/BulkLoadJob.java:
##########
@@ -97,6 +100,7 @@ public BulkLoadJob(EtlJobType jobType, long dbId, String label,
OriginStatement originStmt, UserIdentity userInfo) throws MetaNotFoundException {
super(jobType, dbId, label);
this.originStmt = originStmt;
+ this.queryId = DebugUtil.printId(ConnectContext.get().queryId());
Review Comment:
Hi, i have fixed it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15898: [Enhancement](profile) use queryId of originStatement as the queryId.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15898:
URL: https://github.com/apache/doris/pull/15898#issuecomment-1381987279
PR approved by anyone and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org
[GitHub] [doris] github-actions[bot] commented on pull request #15898: [Enhancement](profile) use queryId of originStatement as the queryId.
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on PR #15898:
URL: https://github.com/apache/doris/pull/15898#issuecomment-1381987217
PR approved by at least one committer and no changes requested.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org