You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@tinkerpop.apache.org by GitBox <gi...@apache.org> on 2020/03/06 13:18:27 UTC

[GitHub] [tinkerpop] FlorianHockmann commented on issue #1257: dotnet: add session connection

FlorianHockmann commented on issue #1257: dotnet: add session connection
URL: https://github.com/apache/tinkerpop/pull/1257#issuecomment-595763604
 
 
   Thanks for the contribution, @heljoyLiu! The PR looks good at a first glance, but I'll need some more time to do a full review.
   I'm not sure if you're aware of that but the Gremlin.NET driver has changed a lot between `3.3-dev` and `3.4-dev`, so if you want this change to go into `3.3-dev` already, then it would be good if you could create another PR that targets `3.4-dev` with this contribution. That would make it a lot easier to get your contribution into all release branches.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services