You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@eventmesh.apache.org by "akashsawan1 (via GitHub)" <gi...@apache.org> on 2023/04/07 11:02:37 UTC
[GitHub] [eventmesh] akashsawan1 opened a new pull request, #3658: ISSUE #3513
akashsawan1 opened a new pull request, #3658:
URL: https://github.com/apache/eventmesh/pull/3658
<!--
(If this PR fixes a GitHub issue, please add `Fixes #<XXX>` or `Closes #<XXX>`.)
-->
Closes #<3513>.
### Motivation
*Explain why you want to make the changes and what problem you're trying to solve.*
- I am contributing for the first time, it will help to keep me motivated to learn and help the community
### Modifications
*Describe the modifications you've done.*
Swapped actual and expected values in the line 50,51,53,54,56-58.
### Documentation
- Does this pull request introduce a new feature? no
- If yes, how is the feature documented? not applicable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 commented on a diff in pull request #3658: ISSUE #3513 Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest] #3513
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 commented on code in PR #3658:
URL: https://github.com/apache/eventmesh/pull/3658#discussion_r1160641350
##########
eventmesh-runtime/src/main/java/org/apache/eventmesh/runtime/core/protocol/http/processor/SendAsyncRemoteEventProcessor.java:
##########
Review Comment:
ISSUE#3408 Do some code optimization[SendAsyncRemoteEventProcessor] #3408
closes<3408>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] Alonexc commented on pull request #3658: ISSUE #3513 Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest] #3513
Posted by "Alonexc (via GitHub)" <gi...@apache.org>.
Alonexc commented on PR #3658:
URL: https://github.com/apache/eventmesh/pull/3658#issuecomment-1502513268
@akashsawan1 Please one issue corresponds to one pr, not one pr fixes multiple issues.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: issues-help@eventmesh.apache.org
[GitHub] [eventmesh] akashsawan1 closed pull request #3658: ISSUE #3513 Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest] #3513
Posted by "akashsawan1 (via GitHub)" <gi...@apache.org>.
akashsawan1 closed pull request #3658: ISSUE #3513 Swap these 2 arguments so they are in the correct order: expected value, actual value.[PravegaStorageConfigTest] #3513
URL: https://github.com/apache/eventmesh/pull/3658
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@eventmesh.apache.org
For additional commands, e-mail: dev-help@eventmesh.apache.org