[jira] [Commented] (PHOENIX-4499) Make QueryPlan.getEstimatedBytesToScan() independent of getExplainPlan() and pull optimize() out of getExplainPlan() - HBase 4.x-HBase-1.2

["Hadoop QA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/PHOENIX-4499?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16303963#comment-16303963 ] 

Hadoop QA commented on PHOENIX-4499:
------------------------------------

{color:red}-1 overall{color}.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12903726/PHOENIX4437-4.x-HBase-1.2.patch
  against 4.x-HBase-1.2 branch at commit 34693843abe4490b54fbd30512bf7d98d0f59c0d.
  ATTACHMENT ID: 12903726

    {color:green}+1 @author{color}.  The patch does not contain any @author tags.

    {color:red}-1 tests included{color}.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    {color:green}+1 javac{color}.  The applied patch does not increase the total number of javac compiler warnings.

    {color:red}-1 release audit{color}.  The applied patch generated 1 release audit warnings (more than the master's current 0 warnings).

    {color:red}-1 lineLengths{color}.  The patch introduces the following lines longer than 100:
    +            StatementPlan compilePlan = compilableStmt.compilePlan(stmt, Sequence.ValueOp.VALIDATE_SEQUENCE);
+            // For a QueryPlan, we need to get its optimized plan; for a MutationPlan, its enclosed QueryPlan
+                compilePlan = stmt.getConnection().getQueryServices().getOptimizer().optimize(stmt, dataPlan);

     {color:red}-1 core tests{color}.  The patch failed these unit tests:
     ./phoenix-core/target/failsafe-reports/TEST-org.apache.phoenix.end2end.TransactionalViewIT

Test results: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1692//testReport/
Release audit warnings: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1692//artifact/patchprocess/patchReleaseAuditWarnings.txt
Console output: https://builds.apache.org/job/PreCommit-PHOENIX-Build/1692//console

This message is automatically generated.

> Make QueryPlan.getEstimatedBytesToScan() independent of getExplainPlan() and pull optimize() out of getExplainPlan() - HBase 4.x-HBase-1.2
> ------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PHOENIX-4499
>                 URL: https://issues.apache.org/jira/browse/PHOENIX-4499
>             Project: Phoenix
>          Issue Type: Improvement
>    Affects Versions: 4.11.0
>            Reporter: Pedro Boado
>            Assignee: Maryann Xue
>             Fix For: 4.14.0
>
>         Attachments: PHOENIX4437-4.x-HBase-1.2.patch
>
>
> Cloned for applying patch to 4.x-HBase-1.2



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)