[GitHub] [netbeans] matthiasblaesing commented on a diff in pull request #4194: Try to generate maven project skeleton from our dependencies

[GitBox <gi...@apache.org>]

matthiasblaesing commented on code in PR #4194:
URL: https://github.com/apache/netbeans/pull/4194#discussion_r898148753


##########
nbbuild/antsrc/org/netbeans/nbbuild/extlibs/VerifyLibsAndLicenses.java:
##########
@@ -76,6 +79,12 @@ public void setNball(File nball) {
     public void setReport(File report) {
         this.reportFile = report;
     }
+    
+    private File mavenfolderFile;
+    /** JUnit-format XML result file to generate, rather than halting the build. */
+    public void setMavenFolder(File report) {

Review Comment:
   This looks strange. The `VerifyLibsAndLicenses` task is pretty specificy. Why is this here? Could this be extracted into a seperate task?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@netbeans.apache.org
For additional commands, e-mail: notifications-help@netbeans.apache.org

For further information about the NetBeans mailing lists, visit:
https://cwiki.apache.org/confluence/display/NETBEANS/Mailing+lists