[GitHub] [guacamole-client] jmuehlner commented on a diff in pull request #770: GUACAMOLE-1594: Update all Java and JavaScript dependencies to latest compatible.

[GitBox <gi...@apache.org>]

jmuehlner commented on code in PR #770:
URL: https://github.com/apache/guacamole-client/pull/770#discussion_r1007161585


##########
extensions/guacamole-auth-jdbc/modules/guacamole-auth-jdbc-base/pom.xml:
##########
@@ -57,14 +57,35 @@
         <dependency>
             <groupId>org.mybatis</groupId>
             <artifactId>mybatis</artifactId>
-            <version>3.5.9</version>
+            <version>3.5.11</version>
         </dependency>
         
         <!-- MyBatis Guice -->
         <dependency>
             <groupId>org.mybatis</groupId>
             <artifactId>mybatis-guice</artifactId>
-            <version>3.10</version>
+            <version>3.17</version>
+            <exclusions>
+
+                <!-- This dependency appears to be necessary only to provide an

Review Comment:
   I understand that this dependency isn't necessary for us, but I'm still unclear why it's being explicitly excluded. Doesn't seem like it could be for license reasons since it's MIT-licensed, and furthermore there's an explicit inclusion in `extensions/pom.xml` for the same artifact.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@guacamole.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org