You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2021/02/16 19:24:43 UTC

[GitHub] [lucene-solr] epugh opened a new pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

epugh opened a new pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381


   This code was mostly written by Michael Suzuki in PR https://github.com/apache/lucene-solr/pull/180,  i just tweaked it to load in Solr 9, and updated the version of ui-grid to the 4.10 version.
   
   
   
   <!--
   _(If you are a project committer then you may remove some/all of the following template.)_
   
   Before creating a pull request, please file an issue in the ASF Jira system for Lucene or Solr:
   
   * https://issues.apache.org/jira/projects/LUCENE
   * https://issues.apache.org/jira/projects/SOLR
   
   You will need to create an account in Jira in order to create an issue.
   
   The title of the PR should reference the Jira issue number in the form:
   
   * LUCENE-####: <short description of problem or changes>
   * SOLR-####: <short description of problem or changes>
   
   LUCENE and SOLR must be fully capitalized. A short description helps people scanning pull requests for items they can work on.
   
   Properly referencing the issue in the title ensures that Jira is correctly updated with code review comments and commits. -->
   
   
   # Description
   
   Add a simple page to Solr Admin for doing SQL queries.
   
   # Solution
   
   Delegates to the `qt=sql` handler and runs the query.  Displays results in basic table.
   
   This UI shows how easy it is to write a SQL query that Solr doesn't like ;-(.   However, it's much easier to use than using Curl.   And may encourage more use of this powerful feature.
   
   # Tests
   
   Please describe the tests you've developed or run to confirm this patch implements the feature or solves the problem.
   
   # Checklist
   
   Please review the following and check all that apply:
   
   - [X ] I have reviewed the guidelines for [How to Contribute](https://wiki.apache.org/solr/HowToContribute) and my code conforms to the standards described there to the best of my ability.
   - [ X] I have created a Jira issue and added the issue ID to my pull request title.
   - [ X] I have given Solr maintainers [access](https://help.github.com/en/articles/allowing-changes-to-a-pull-request-branch-created-from-a-fork) to contribute to my PR branch. (optional but recommended)
   - [X ] I have developed this patch against the `master` branch.
   - [ X] I have run `./gradlew check`.
   - [ ] I have added tests for my changes.
   - [X ] I have added documentation for the [Ref Guide](https://github.com/apache/lucene-solr/tree/master/solr/solr-ref-guide) (for Solr changes only).
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh merged pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

Posted by GitBox <gi...@apache.org>.
epugh merged pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381#issuecomment-780799691


   I think I'm done with this PR!   I'd love a review and then I'll commit it.   I could see backporting it to 8.x as well.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381#issuecomment-781395420


   ahh!  I didn't know abouit that!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381#issuecomment-780064396


   @michaelsuzukisagi I'd love your review.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381#issuecomment-781373407


   How do we get a clarificaiton on this?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381#issuecomment-781371781


   are you referring to the `/solr/licenses/` directory?   A `/solr/licenses/ui-grid-LICENSE.txt` and `/solr/licenses/ui-grid-NOTICE.txt`?
   
   Be nice to add this to the dev docs!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] janhoy commented on pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

Posted by GitBox <gi...@apache.org>.
janhoy commented on pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381#issuecomment-781379073


   So I think you add a few lines at bottom of `solr/LICENSE.txt`, you already see the jquery part there.
   I have been adding some sections to `solr/NOTICE.txt` earlier, but I think some of those really belong in LICENSE.txt instead, since only some projects and licenses require use of NOTICE. So a cleanup is needed too...


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


[GitHub] [lucene-solr] epugh commented on pull request #2381: SOLR-8138: Simple UI for issuing SQL queries

Posted by GitBox <gi...@apache.org>.
epugh commented on pull request #2381:
URL: https://github.com/apache/lucene-solr/pull/2381#issuecomment-781372454


   also, I don't see any licenses for the JS libraries....


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org