You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@kudu.apache.org by "Dan Burkert (Code Review)" <ge...@cloudera.org> on 2016/04/06 21:06:28 UTC

[kudu-CR] [c++-client] abstract scanner configuration

Hello Adar Dembo, Todd Lipcon,

I'd like you to do a code review.  Please visit

    http://gerrit.cloudera.org:8080/2726

to review the following change.

Change subject: [c++-client] abstract scanner configuration
......................................................................

[c++-client] abstract scanner configuration

Unlike the Java client, the c++ client configures scan options directly on the
KuduScanner. This commit adds an internal class, ScanConfiguration, that takes
over responsibility for configuring scans from the KuduScanner.  KuduScanner is
updated to hold a ScanConfiguration internally. The ScanConfiguration will be
used internally in the forthecoming scan token builder API.

Change-Id: Id3d5b27f4a0ae6cd1500f17f96b7043590affd92
---
M src/kudu/client/CMakeLists.txt
M src/kudu/client/client-test.cc
M src/kudu/client/client.cc
A src/kudu/client/scan_configuration.cc
A src/kudu/client/scan_configuration.h
M src/kudu/client/scan_predicate.h
M src/kudu/client/scanner-internal.cc
M src/kudu/client/scanner-internal.h
M src/kudu/client/schema.h
9 files changed, 439 insertions(+), 181 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/26/2726/1
-- 
To view, visit http://gerrit.cloudera.org:8080/2726
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-MessageType: newchange
Gerrit-Change-Id: Id3d5b27f4a0ae6cd1500f17f96b7043590affd92
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Dan Burkert <da...@cloudera.com>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Todd Lipcon <to...@apache.org>