[GitHub] [kafka] mumrah commented on a change in pull request #10714: MINOR: add ConfigUtils method for printing configurations

[GitBox <gi...@apache.org>]

mumrah commented on a change in pull request #10714:
URL: https://github.com/apache/kafka/pull/10714#discussion_r635452472



##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -601,7 +601,8 @@ class DynamicBrokerConfig(private val kafkaConfig: KafkaConfig) extends Logging
     }
 
     if (!validateOnly) {
-      info(s"Reconfiguring $reconfigurable, updated configs: $updatedConfigNames custom configs: $newCustomConfigs")
+      info(s"Reconfiguring $reconfigurable, updated configs: $updatedConfigNames " +
+        s"custom configs: ${ConfigUtils.configMapToRedactedString(newCustomConfigs, KafkaConfig.configDef)}")

Review comment:
       nit: alignment

##########
File path: core/src/main/scala/kafka/server/DynamicBrokerConfig.scala
##########
@@ -34,7 +34,7 @@ import org.apache.kafka.common.metrics.MetricsReporter
 import org.apache.kafka.common.config.types.Password
 import org.apache.kafka.common.network.{ListenerName, ListenerReconfigurable}
 import org.apache.kafka.common.security.authenticator.LoginManager
-import org.apache.kafka.common.utils.Utils
+import org.apache.kafka.common.utils.{ConfigUtils, Utils};

Review comment:
       nit: errant semicolon 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org