You are viewing a plain text version of this content. The canonical link for it is here.
Posted to common-issues@hadoop.apache.org by "Hudson (JIRA)" <ji...@apache.org> on 2015/03/25 08:43:53 UTC
[jira] [Commented] (HADOOP-11741) Add LOG.isDebugEnabled() guard
for some LOG.debug()
[ https://issues.apache.org/jira/browse/HADOOP-11741?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14379437#comment-14379437 ]
Hudson commented on HADOOP-11741:
---------------------------------
FAILURE: Integrated in Hadoop-trunk-Commit #7426 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/7426/])
HADOOP-11741. Add LOG.isDebugEnabled() guard for some LOG.debug(). Contributed by Walter Su. (ozawa: rev 5582b0f1d469e7c98811a341c4b4c78eaa64ede5)
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/crypto/key/JavaKeyStoreProvider.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/conf/Configuration.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/Server.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ipc/RPC.java
* hadoop-common-project/hadoop-common/CHANGES.txt
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/metrics/ganglia/GangliaContext31.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/ha/ActiveStandbyElector.java
* hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/security/ssl/FileBasedKeyStoresFactory.java
> Add LOG.isDebugEnabled() guard for some LOG.debug()
> ---------------------------------------------------
>
> Key: HADOOP-11741
> URL: https://issues.apache.org/jira/browse/HADOOP-11741
> Project: Hadoop Common
> Issue Type: Improvement
> Reporter: Walter Su
> Assignee: Walter Su
> Fix For: 2.8.0
>
> Attachments: HADOOP-11741.001.patch, HADOOP-11741.002.patch
>
>
> {{isDebugEnabled()}} is optional. But when there are :
> 1. lots of concatenating Strings
> 2. complicated function calls
> in the arguments, {{LOG.debug(..)}} should be guarded with {{LOG.isDebugEnabled()}} to avoid unnecessary arguments evaluation and impove performance.
--
This message was sent by Atlassian JIRA
(v6.3.4#6332)