You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@geode.apache.org by "ASF subversion and git services (Jira)" <ji...@apache.org> on 2020/01/08 18:27:00 UTC

[jira] [Commented] (GEODE-7658) Remove hostname resolution methods from TcpSocketCreator

    [ https://issues.apache.org/jira/browse/GEODE-7658?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17010897#comment-17010897 ] 

ASF subversion and git services commented on GEODE-7658:
--------------------------------------------------------

Commit 8850167a2e92322d33a8fac7f42803f7d3e92f77 in geode's branch refs/heads/develop from Dan Smith
[ https://gitbox.apache.org/repos/asf?p=geode.git;h=8850167 ]

GEODE-7658: Removing hostname resolution from TcpSocketCreatorAdapter

We didn't need these methods on TcpSocketCreatorAdapter.
* resolveDns is based on whether network partition detection is enabled, which
we can access directly in membership.

* getHostName uses a static hostname cache that we don't need to use
for membership when creating the local address.

* getLocalHost has moved to a utility in geode-common.


> Remove hostname resolution methods from TcpSocketCreator
> --------------------------------------------------------
>
>                 Key: GEODE-7658
>                 URL: https://issues.apache.org/jira/browse/GEODE-7658
>             Project: Geode
>          Issue Type: Improvement
>          Components: membership
>            Reporter: Dan Smith
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> TcpSocketCreator has a few methods related to hostname resolution that are not necessary:
> * resolveDns is based on
> whether network partition detection is enabled, which we can access directly in
> membership
> * getHostName uses a static hostname cache that we don't need to use
> for membership in the one place where SocketCreator.getHostName was called
> * getLocalHost has moved to a utility in geode-common, so we don't need to abstract this away.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)