You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@cassandra.apache.org by jb...@apache.org on 2012/07/25 20:15:42 UTC
[3/5] git commit: add comment to #4452
add comment to #4452
Project: http://git-wip-us.apache.org/repos/asf/cassandra/repo
Commit: http://git-wip-us.apache.org/repos/asf/cassandra/commit/f46232c0
Tree: http://git-wip-us.apache.org/repos/asf/cassandra/tree/f46232c0
Diff: http://git-wip-us.apache.org/repos/asf/cassandra/diff/f46232c0
Branch: refs/heads/trunk
Commit: f46232c0b02f27c5177bd453a6d0b0f6441c2499
Parents: 06bdd3e
Author: Jonathan Ellis <jb...@apache.org>
Authored: Wed Jul 25 13:15:21 2012 -0500
Committer: Jonathan Ellis <jb...@apache.org>
Committed: Wed Jul 25 13:15:21 2012 -0500
----------------------------------------------------------------------
.../cassandra/service/StorageServiceMBean.java | 6 ++++--
1 files changed, 4 insertions(+), 2 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/cassandra/blob/f46232c0/src/java/org/apache/cassandra/service/StorageServiceMBean.java
----------------------------------------------------------------------
diff --git a/src/java/org/apache/cassandra/service/StorageServiceMBean.java b/src/java/org/apache/cassandra/service/StorageServiceMBean.java
index 0872e2b..c4c6a1d 100644
--- a/src/java/org/apache/cassandra/service/StorageServiceMBean.java
+++ b/src/java/org/apache/cassandra/service/StorageServiceMBean.java
@@ -401,8 +401,10 @@ public interface StorageServiceMBean
public void loadNewSSTables(String ksName, String cfName);
/**
- * Return a List of Tokens representing a sample of keys
- * across all ColumnFamilyStores
+ * Return a List of Tokens representing a sample of keys across all ColumnFamilyStores.
+ *
+ * Note: this should be left as an operation, not an attribute (methods starting with "get")
+ * to avoid sending potentially multiple MB of data when accessing this mbean by default. See CASSANDRA-4452.
*
* @return set of Tokens as Strings
*/