[GitHub] [incubator-pegasus] levy5307 commented on issue #796: change secondary commit to async execute in background thread

[GitBox <gi...@apache.org>]

levy5307 commented on issue #796:
URL: https://github.com/apache/incubator-pegasus/issues/796#issuecomment-898360038


   > I agree, however, its implementation may be more simple but no background task: we just need put [prepare](https://github.com/XiaoMi/rdsn/blob/master/src/replica/replica_2pc.cpp#L488) after the `ack_prepare_message`, for [example](https://github.com/XiaoMi/rdsn/blob/7e3eab786fb5e0675d84eac22d5508b03538d5f4/src/replica/replica_2pc.cpp#L592):
   > 
   > ```diff
   >     if (err == ERR_OK && status() != partition_status::PS_ERROR) {
   >         _private_log->append(mu, LPC_WRITE_REPLICATION_LOG_COMMON, &_tracker, nullptr);
   >     }
   > + prepre.....
   > ```
   
   Sounds reasonable :）


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@pegasus.apache.org
For additional commands, e-mail: dev-help@pegasus.apache.org