[jira] [Commented] (BEAM-927) Findbugs doesn't pass in JMS

["ASF GitHub Bot (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/BEAM-927?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15664200#comment-15664200 ] 

ASF GitHub Bot commented on BEAM-927:
-------------------------------------

GitHub user jbonofre opened a pull request:

    https://github.com/apache/incubator-beam/pull/1357

    [BEAM-927] Fix findbugs and re-enable Maven plugin in JmsIO

    Be sure to do all of the following to help us incorporate your contribution
    quickly and easily:
    
     - [X] Make sure the PR title is formatted like:
       `[BEAM-<Jira issue #>] Description of pull request`
     - [X] Make sure tests pass via `mvn clean verify`. (Even better, enable
           Travis-CI on your fork and ensure the whole test matrix passes).
     - [X] Replace `<Jira issue #>` in the title with the actual Jira issue
           number, if there is one.
     - [X] If this contribution is large, please file an Apache
           [Individual Contributor License Agreement](https://www.apache.org/licenses/icla.txt).
    
    ---
    


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/jbonofre/incubator-beam BEAM-927

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-beam/pull/1357.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #1357
    
----
commit 5cd00e5bd43b47b3cb7296001344310ca6f97305
Author: Jean-Baptiste Onofré <jb...@apache.org>
Date:   2016-11-14T15:27:56Z

    [BEAM-927] Fix findbugs and re-enable Maven plugin in JmsIO

----


> Findbugs doesn't pass in JMS
> ----------------------------
>
>                 Key: BEAM-927
>                 URL: https://issues.apache.org/jira/browse/BEAM-927
>             Project: Beam
>          Issue Type: Bug
>          Components: sdk-java-extensions
>            Reporter: Daniel Halperin
>            Assignee: Jean-Baptiste Onofré
>
> {code}
> [INFO] --- findbugs-maven-plugin:3.0.1:check (default) @ beam-sdks-java-io-jms ---
> [INFO] BugInstance size is 2
> [INFO] Error size is 0
> [INFO] Total bugs: 2
> [INFO] Class org.apache.beam.sdk.io.jms.JmsRecord defines non-transient non-serializable instance field jmsDestination [org.apache.beam.sdk.io.jms.JmsRecord] In JmsRecord.java
> [INFO] Class org.apache.beam.sdk.io.jms.JmsRecord defines non-transient non-serializable instance field jmsReplyTo [org.apache.beam.sdk.io.jms.JmsRecord] In JmsRecord.java
> [INFO] 
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)