You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2020/04/10 12:41:29 UTC
[GitHub] [incubator-mxnet] hgt312 opened a new pull request #18017: [Numpy]
New FFIs for Operator: tile, trace, transpose
hgt312 opened a new pull request #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017
| Old FFI (ctypes) (us) | New FFI (cython) (us)
-- | -- | --
tile | 29.95 | 7.3
trace | 20.24 | 6.43
transpose | 22.42 | 6.07
Using 2x2 tensor as tensor input.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] haojin2 merged pull request #18017: [Numpy] New
FFIs for Operator: tile, trace, transpose
Posted by GitBox <gi...@apache.org>.
haojin2 merged pull request #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18017: [Numpy] New
FFIs for Operator: tile, trace, transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017#issuecomment-612328356
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18017: [Numpy] New
FFIs for Operator: tile, trace, transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017#issuecomment-615002784
Jenkins CI successfully triggered : [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hzfan commented on a change in pull request
#18017: [Numpy] New FFIs for Operator: tile, trace, transpose
Posted by GitBox <gi...@apache.org>.
hzfan commented on a change in pull request #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017#discussion_r409995466
##########
File path: src/api/operator/tensor/matrix_op.cc
##########
@@ -68,4 +68,25 @@ MXNET_REGISTER_API("_npi.clip")
}
});
+MXNET_REGISTER_API("_npi.tile")
+.set_body([](runtime::MXNetArgs args, runtime::MXNetRetValue* ret) {
+ using namespace runtime;
+ const nnvm::Op* op = Op::Get("_npi_tile");
+ nnvm::NodeAttrs attrs;
+ op::TileParam param;
+ if (args[1].type_code() == kDLInt) {
+ param.reps = Tuple<int>(1, args[1].operator int64_t());
+ } else {
+ param.reps = Tuple<int>(args[1].operator ObjectRef());
Review comment:
Indent
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] haojin2 commented on issue #18017: [Numpy] New
FFIs for Operator: tile, trace, transpose
Posted by GitBox <gi...@apache.org>.
haojin2 commented on issue #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017#issuecomment-615002756
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] mxnet-bot commented on issue #18017: [Numpy] New
FFIs for Operator: tile, trace, transpose
Posted by GitBox <gi...@apache.org>.
mxnet-bot commented on issue #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017#issuecomment-612012449
Hey @hgt312 , Thanks for submitting the PR
All tests are already queued to run once. If tests fail, you can trigger one or more tests again with the following commands:
- To trigger all jobs: @mxnet-bot run ci [all]
- To trigger specific jobs: @mxnet-bot run ci [job1, job2]
***
**CI supported jobs**: [miscellaneous, centos-gpu, clang, unix-cpu, windows-cpu, centos-cpu, windows-gpu, edge, unix-gpu, sanity, website]
***
_Note_:
Only following 3 categories can trigger CI :PR Author, MXNet Committer, Jenkins Admin.
All CI tests must pass before the PR can be merged.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] haojin2 commented on issue #18017: [Numpy] New
FFIs for Operator: tile, trace, transpose
Posted by GitBox <gi...@apache.org>.
haojin2 commented on issue #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017#issuecomment-612329259
@hzfan Can you double check on the FFI part?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [incubator-mxnet] hgt312 commented on issue #18017: [Numpy] New
FFIs for Operator: tile, trace, transpose
Posted by GitBox <gi...@apache.org>.
hgt312 commented on issue #18017: [Numpy] New FFIs for Operator: tile, trace, transpose
URL: https://github.com/apache/incubator-mxnet/pull/18017#issuecomment-612328343
@mxnet-bot run ci [unix-gpu]
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services