You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@deltaspike.apache.org by "Gerhard Petracek (Created) (JIRA)" <ji...@apache.org> on 2011/12/21 14:23:30 UTC
[jira] [Created] (DELTASPIKE-24) Deactivatable
Deactivatable
-------------
Key: DELTASPIKE-24
URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
Project: DeltaSpike
Issue Type: New Feature
Components: Core
Reporter: Gerhard Petracek
Assignee: Gerhard Petracek
original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek resolved DELTASPIKE-24.
----------------------------------------
Resolution: Fixed
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.1-SNAPSHOT
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-24) Deactivatable
Posted by "Mark Struberg (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg updated DELTASPIKE-24:
------------------------------------
Attachment: DELTASPIKE-24.patch
please review this patch.
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.1
>
> Attachments: DELTASPIKE-24.patch
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek closed DELTASPIKE-24.
--------------------------------------
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.1-incubating
>
> Attachments: DELTASPIKE-24.patch
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-24) Deactivatable
Posted by "Mark Struberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190677#comment-13190677 ]
Mark Struberg commented on DELTASPIKE-24:
-----------------------------------------
> currently they just can't use the helper which is used by deltaspike itself.
The clear intent was that our Deactivatable stuff is also usable for Seam3, CODI and other custom Extension libs.
This is now easily doable by just using
ClassDeactivation
public static synchronized boolean isActivated(Class<? extends Deactivatable> deactivatableClazz)
e.g.
if (!ClassDeactivation.isActivated(getClass())) return;
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.1
>
> Attachments: DELTASPIKE-24.patch
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek resolved DELTASPIKE-24.
----------------------------------------
Resolution: Fixed
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.1-incubating
>
> Attachments: DELTASPIKE-24.patch
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek reopened DELTASPIKE-24:
----------------------------------------
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 1.0.0-incubating
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Resolved] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Resolved) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek resolved DELTASPIKE-24.
----------------------------------------
Resolution: Fixed
Fix Version/s: 1.0.0-incubating
we agreed on adding it - see http://s.apache.org/Ar0
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 1.0.0-incubating
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Closed] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Closed) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek closed DELTASPIKE-24.
--------------------------------------
Resolution: Fixed
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.1-incubating
>
> Attachments: DELTASPIKE-24.patch
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek reopened DELTASPIKE-24:
----------------------------------------
Assignee: Gerhard Petracek (was: Mark Struberg)
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 0.1-incubating
>
> Attachments: DELTASPIKE-24.patch
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190669#comment-13190669 ]
Gerhard Petracek commented on DELTASPIKE-24:
--------------------------------------------
i'm ok with replacing the log with an exception
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.1
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Reopened] (DELTASPIKE-24) Deactivatable
Posted by "Mark Struberg (Reopened) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Mark Struberg reopened DELTASPIKE-24:
-------------------------------------
Assignee: Mark Struberg (was: Gerhard Petracek)
a review revealed the following areas which could be improved
* simplify deactivation logic
* allow overriding of deactivation
* functionality must be available from the core-api to be usable in 3rd-party Extensions
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.1
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Updated] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Updated) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Gerhard Petracek updated DELTASPIKE-24:
---------------------------------------
Comment: was deleted
(was: we agreed on adding it - see http://s.apache.org/Ar0)
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Gerhard Petracek
> Fix For: 1.0.0-incubating
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-24) Deactivatable
Posted by "Gerhard Petracek (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190671#comment-13190671 ]
Gerhard Petracek commented on DELTASPIKE-24:
--------------------------------------------
3rd party extensions can use it already by loading all ClassDeactivator implementations. currently they just can't use the helper which is used by deltaspike itself.
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.1
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
[jira] [Commented] (DELTASPIKE-24) Deactivatable
Posted by "Mark Struberg (Commented) (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/DELTASPIKE-24?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13190653#comment-13190653 ]
Mark Struberg commented on DELTASPIKE-24:
-----------------------------------------
The current code is pretty nice if a given ClassDeactivator doesn't exist.
> currentClassDeactivator =
> ClassUtils.tryToInstantiateClassForName(classDeactivatorClassName, ClassDeactivator.class);
> ... if null... LOG.warning(classDeactivatorClassName + " can't be instantiated");
I think this is way to nice. If someone configured a not existing ClassDeactivator, then the system should just blow up. This is most probably a misspelling on the class name and thus a serious problem.
> Deactivatable
> -------------
>
> Key: DELTASPIKE-24
> URL: https://issues.apache.org/jira/browse/DELTASPIKE-24
> Project: DeltaSpike
> Issue Type: New Feature
> Components: Core
> Reporter: Gerhard Petracek
> Assignee: Mark Struberg
> Fix For: 0.1
>
>
> original feature: https://issues.apache.org/jira/browse/EXTCDI-66
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira