You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@atlas.apache.org by Nixon Rodrigues <ni...@freestoneinfotech.com> on 2017/04/06 14:21:11 UTC

Review Request 58234: ATLAS-1697 : import-hive.sh script logs debug/info logs on console instead of import-hive.log log file

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58234/
-----------------------------------------------------------

Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.


Bugs: ATLAS-1697
    https://issues.apache.org/jira/browse/ATLAS-1697


Repository: atlas


Description
-------

Found the issue of hive import script logs not being appended to log file.

Solution Implementation to solve the issue.

1) Have a atlas-hive-import-log4j.xml dedicated to import hive script process inside hive-bridge module.
2) Change the current reference of atlas-logj.xml and refer to atlas-hive-import-log4j.xml


Diffs
-----

  addons/hive-bridge/src/bin/import-hive.sh 1032aa2 
  addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml PRE-CREATION 


Diff: https://reviews.apache.org/r/58234/diff/1/


Testing
-------

Tested the logs appending after running the import-hive script.
Build and testcases are executing fine.


Thanks,

Nixon Rodrigues


Re: Review Request 58234: ATLAS-1697 : import-hive.sh script logs debug/info logs on console instead of import-hive.log log file

Posted by Apoorv Naik <na...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/58234/#review171216
-----------------------------------------------------------


Ship it!




Ship It!

- Apoorv Naik


On April 6, 2017, 2:21 p.m., Nixon Rodrigues wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/58234/
> -----------------------------------------------------------
> 
> (Updated April 6, 2017, 2:21 p.m.)
> 
> 
> Review request for atlas, Apoorv Naik, Madhan Neethiraj, and Sarath Subramanian.
> 
> 
> Bugs: ATLAS-1697
>     https://issues.apache.org/jira/browse/ATLAS-1697
> 
> 
> Repository: atlas
> 
> 
> Description
> -------
> 
> Found the issue of hive import script logs not being appended to log file.
> 
> Solution Implementation to solve the issue.
> 
> 1) Have a atlas-hive-import-log4j.xml dedicated to import hive script process inside hive-bridge module.
> 2) Change the current reference of atlas-logj.xml and refer to atlas-hive-import-log4j.xml
> 
> 
> Diffs
> -----
> 
>   addons/hive-bridge/src/bin/import-hive.sh 1032aa2 
>   addons/hive-bridge/src/main/resources/atlas-hive-import-log4j.xml PRE-CREATION 
> 
> 
> Diff: https://reviews.apache.org/r/58234/diff/1/
> 
> 
> Testing
> -------
> 
> Tested the logs appending after running the import-hive script.
> Build and testcases are executing fine.
> 
> 
> Thanks,
> 
> Nixon Rodrigues
> 
>