You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by Damodar Reddy Talakanti <da...@citrix.com> on 2013/12/18 12:42:23 UTC
Review Request 16350: Fixed it in ClusterManagerImpl while resetting the
heart beat connection
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16350/
-----------------------------------------------------------
Review request for cloudstack and Abhinandan Prateek.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5457
Repository: cloudstack-git
Description
-------
Due to changes in underlying DAO layer to re throw exceptionsback to the caller DB HA functionality is broken as MS is not going down even all dbs are down. Fixed this by catching exceptions in ClusterManagerImpl and take decision based on it.
Diffs
-----
framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 1c10a95
Diff: https://reviews.apache.org/r/16350/diff/
Testing
-------
Testing is done in the following use cases
1. With db ha not enabled
2. with db ha enabled and
- Shot down Master
- Shut down slave
3. With db ha enabled
- shut down 2nd db
- shot down 1st db
4. with dbha enabled
- shut down 1st db
- up the 1st db
- shut down 2nd db
- shut down 1 st db
Thanks,
Damodar Reddy Talakanti
Re: Review Request 16350: Fixed it in ClusterManagerImpl while resetting the
heart beat connection
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16350/#review30690
-----------------------------------------------------------
Ship it!
4.3 -> 8c29760db7275d31d720aa88e8d8a89494d31323
- Koushik Das
On Dec. 19, 2013, 10:43 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16350/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 10:43 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5457
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Due to changes in underlying DAO layer to re throw exceptionsback to the caller DB HA functionality is broken as MS is going down if master is down and salve is up. Fixed this by catching exceptions in ClusterManagerImpl and take decision based on it.
>
>
> Diffs
> -----
>
> framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 1c10a95
>
> Diff: https://reviews.apache.org/r/16350/diff/
>
>
> Testing
> -------
>
> Testing is done in the following use cases
> 1. With db ha not enabled
> 2. with db ha enabled and
> - Shut down Master
> - Shut down slave
> 3. With db ha enabled
> - shut down 2nd db
> - shot down 1st db
> 4. with dbha enabled
> - shut down 1st db
> - up the 1st db
> - shut down 2nd db
> - shut down 1 st db
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 16350: Fixed it in ClusterManagerImpl while resetting the
heart beat connection
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16350/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 11:34 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
New patch for master with fixed merge conflicts
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5457
Repository: cloudstack-git
Description
-------
Due to changes in underlying DAO layer to re throw exceptionsback to the caller DB HA functionality is broken as MS is going down if master is down and salve is up. Fixed this by catching exceptions in ClusterManagerImpl and take decision based on it.
Diffs (updated)
-----
framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java c7c3710
Diff: https://reviews.apache.org/r/16350/diff/
Testing
-------
Testing is done in the following use cases
1. With db ha not enabled
2. with db ha enabled and
- Shut down Master
- Shut down slave
3. With db ha enabled
- shut down 2nd db
- shot down 1st db
4. with dbha enabled
- shut down 1st db
- up the 1st db
- shut down 2nd db
- shut down 1 st db
Thanks,
Damodar Reddy Talakanti
Re: Review Request 16350: Fixed it in ClusterManagerImpl while resetting the
heart beat connection
Posted by Koushik Das <ko...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16350/#review30691
-----------------------------------------------------------
Patch doesn't apply on master. Please upload a new one.
- Koushik Das
On Dec. 19, 2013, 10:43 a.m., Damodar Reddy Talakanti wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/16350/
> -----------------------------------------------------------
>
> (Updated Dec. 19, 2013, 10:43 a.m.)
>
>
> Review request for cloudstack, Abhinandan Prateek and Koushik Das.
>
>
> Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457
> https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5457
>
>
> Repository: cloudstack-git
>
>
> Description
> -------
>
> Due to changes in underlying DAO layer to re throw exceptionsback to the caller DB HA functionality is broken as MS is going down if master is down and salve is up. Fixed this by catching exceptions in ClusterManagerImpl and take decision based on it.
>
>
> Diffs
> -----
>
> framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 1c10a95
>
> Diff: https://reviews.apache.org/r/16350/diff/
>
>
> Testing
> -------
>
> Testing is done in the following use cases
> 1. With db ha not enabled
> 2. with db ha enabled and
> - Shut down Master
> - Shut down slave
> 3. With db ha enabled
> - shut down 2nd db
> - shot down 1st db
> 4. with dbha enabled
> - shut down 1st db
> - up the 1st db
> - shut down 2nd db
> - shut down 1 st db
>
>
> Thanks,
>
> Damodar Reddy Talakanti
>
>
Re: Review Request 16350: Fixed it in ClusterManagerImpl while resetting the
heart beat connection
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16350/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 10:43 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Changes
-------
Description was wrong..corrected the same
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5457
Repository: cloudstack-git
Description (updated)
-------
Due to changes in underlying DAO layer to re throw exceptionsback to the caller DB HA functionality is broken as MS is going down if master is down and salve is up. Fixed this by catching exceptions in ClusterManagerImpl and take decision based on it.
Diffs
-----
framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 1c10a95
Diff: https://reviews.apache.org/r/16350/diff/
Testing
-------
Testing is done in the following use cases
1. With db ha not enabled
2. with db ha enabled and
- Shut down Master
- Shut down slave
3. With db ha enabled
- shut down 2nd db
- shot down 1st db
4. with dbha enabled
- shut down 1st db
- up the 1st db
- shut down 2nd db
- shut down 1 st db
Thanks,
Damodar Reddy Talakanti
Re: Review Request 16350: Fixed it in ClusterManagerImpl while resetting the
heart beat connection
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16350/
-----------------------------------------------------------
(Updated Dec. 19, 2013, 10:29 a.m.)
Review request for cloudstack, Abhinandan Prateek and Koushik Das.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5457
Repository: cloudstack-git
Description
-------
Due to changes in underlying DAO layer to re throw exceptionsback to the caller DB HA functionality is broken as MS is not going down even all dbs are down. Fixed this by catching exceptions in ClusterManagerImpl and take decision based on it.
Diffs
-----
framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 1c10a95
Diff: https://reviews.apache.org/r/16350/diff/
Testing
-------
Testing is done in the following use cases
1. With db ha not enabled
2. with db ha enabled and
- Shut down Master
- Shut down slave
3. With db ha enabled
- shut down 2nd db
- shot down 1st db
4. with dbha enabled
- shut down 1st db
- up the 1st db
- shut down 2nd db
- shut down 1 st db
Thanks,
Damodar Reddy Talakanti
Re: Review Request 16350: Fixed it in ClusterManagerImpl while resetting the
heart beat connection
Posted by Damodar Reddy Talakanti <da...@citrix.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/16350/
-----------------------------------------------------------
(Updated Dec. 18, 2013, 11:55 a.m.)
Review request for cloudstack and Abhinandan Prateek.
Bugs: https://issues.apache.org/jira/browse/CLOUDSTACK-5457
https://issues.apache.org/jira/browse/https://issues.apache.org/jira/browse/CLOUDSTACK-5457
Repository: cloudstack-git
Description
-------
Due to changes in underlying DAO layer to re throw exceptionsback to the caller DB HA functionality is broken as MS is not going down even all dbs are down. Fixed this by catching exceptions in ClusterManagerImpl and take decision based on it.
Diffs
-----
framework/cluster/src/com/cloud/cluster/ClusterManagerImpl.java 1c10a95
Diff: https://reviews.apache.org/r/16350/diff/
Testing (updated)
-------
Testing is done in the following use cases
1. With db ha not enabled
2. with db ha enabled and
- Shut down Master
- Shut down slave
3. With db ha enabled
- shut down 2nd db
- shot down 1st db
4. with dbha enabled
- shut down 1st db
- up the 1st db
- shut down 2nd db
- shut down 1 st db
Thanks,
Damodar Reddy Talakanti