[GitHub] [james-project] woj-tek commented on a diff in pull request #1619: JAMES-3922: Enforce non-null Property contract and add missing null-check in Prope

["woj-tek (via GitHub)" <gi...@apache.org>]

woj-tek commented on code in PR #1619:
URL: https://github.com/apache/james-project/pull/1619#discussion_r1247304004


##########
mailbox/store/src/main/java/org/apache/james/mailbox/store/mail/model/Property.java:
##########
@@ -51,11 +53,11 @@ public class Property {
      * @param localName not null
      * @param value not null
      */
-    public Property(String namespace, String localName, String value) {
+    public Property(@NonNull String namespace, @NonNull String localName, @NonNull String value) {

Review Comment:
   Annotation is descriptive, but I also added explicit checks inside via `Objects.requireNonNull()`



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@james.apache.org
For additional commands, e-mail: notifications-help@james.apache.org