You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/10/13 09:30:38 UTC
[GitHub] [skywalking] wu-sheng opened a new pull request #7918: Message Queue performance and consuming latency monitoring
wu-sheng opened a new pull request #7918:
URL: https://github.com/apache/skywalking/pull/7918
<!--
⚠️ Please make sure to read this template first, pull requests that don't accord with this template
maybe closed without notice.
Texts surrounded by `<` and `>` are meant to be replaced by you, e.g. <framework name>, <issue number>.
Put an `x` in the `[ ]` to mark the item as CHECKED. `[x]`
-->
<!-- ==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👇 ====
### Fix <bug description or the bug issue number or bug issue link>
- [ ] Add a unit test to verify that the fix works.
- [ ] Explain briefly why the bug exists and how to fix it.
==== 🐛 Remove this line WHEN AND ONLY WHEN you're fixing a bug, follow the checklist 👆 ==== -->
<!-- ==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👇 ====
### Improve the performance of <class or module or ...>
- [ ] Add a benchmark for the improvement, refer to [the existing ones](https://github.com/apache/skywalking/blob/master/apm-commons/apm-datacarrier/src/test/java/org/apache/skywalking/apm/commons/datacarrier/LinkedArrayBenchmark.java)
- [ ] The benchmark result.
```text
<Paste the benchmark results here>
```
- [ ] Links/URLs to the theory proof or discussion articles/blogs. <links/URLs here>
==== 📈 Remove this line WHEN AND ONLY WHEN you're improving the performance, follow the checklist 👆 ==== -->
<!-- ==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👇 ====
### <Feature description>
- [ ] If this is non-trivial feature, paste the links/URLs to the design doc.
- [ ] Update the documentation to include this new feature.
- [ ] Tests(including UT, IT, E2E) are added to verify the new feature.
- [ ] If it's UI related, attach the screenshots below.
==== 🆕 Remove this line WHEN AND ONLY WHEN you're adding a new feature, follow the checklist 👆 ==== -->
- [x] If this pull request closes/resolves/fixes an existing issue, replace the issue number. Closes #7828.
- [x] Update the [`CHANGES` log](https://github.com/apache/skywalking/blob/master/CHANGES.md).
* Support `!= null` in OAL engine.
* Add `Message Queue Consuming Count` metric for MQ consuming service and endpoint.
* Add `Message Queue Avg Consuming Latency` metric for MQ consuming service and endpoint.
* Document with a new menu in the `tracing` catalog is added
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng merged pull request #7918: Message Queue performance and consuming latency monitoring
Posted by GitBox <gi...@apache.org>.
wu-sheng merged pull request #7918:
URL: https://github.com/apache/skywalking/pull/7918
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7918: Message Queue performance and consuming latency monitoring
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7918:
URL: https://github.com/apache/skywalking/pull/7918#issuecomment-942110266
This is what SkyWalking could do in default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] wu-sheng commented on pull request #7918: Message Queue performance and consuming latency monitoring
Posted by GitBox <gi...@apache.org>.
wu-sheng commented on pull request #7918:
URL: https://github.com/apache/skywalking/pull/7918#issuecomment-942110266
This is what SkyWalking could do in default.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7918: Message Queue performance and consuming latency monitoring
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7918:
URL: https://github.com/apache/skywalking/pull/7918#discussion_r727901734
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/All.java
##########
@@ -73,6 +72,6 @@ public String getEntityId() {
private Map<String, String> originalTags;
public String getTag(String key) {
- return originalTags.getOrDefault(key, Const.EMPTY_STRING);
+ return originalTags.getOrDefault(key, null);
Review comment:
```suggestion
return originalTags.get(key);
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/Endpoint.java
##########
@@ -100,6 +99,6 @@ public void prepare() {
}
public String getTag(String key) {
- return originalTags.getOrDefault(key, Const.EMPTY_STRING);
+ return originalTags.getOrDefault(key, null);
Review comment:
```suggestion
return originalTags.get(key);
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceInstance.java
##########
@@ -102,6 +100,6 @@ public void prepare() {
}
public String getTag(String key) {
- return originalTags.getOrDefault(key, Const.EMPTY_STRING);
+ return originalTags.getOrDefault(key, null);
Review comment:
```suggestion
return originalTags.get(key);
```
##########
File path: docs/en/setup/backend/mq.md
##########
@@ -0,0 +1,14 @@
+# Message Queue performance and consuming latency monitoring
+
+Message Queue server plays an important role in today's distributed system, in order to reduce the length and latency of
+blocking RPC, and eventually improve user experience. But in this async way, the measure for queue consuming traffic and
+latency becomes significant.
+
+Since 8.9.0, SkyWalking leverages native tracing agent and [**Extension Header
+Item** of SkyWalking Cross Process Propagation Headers Protocol v3](../../protocols/skywalking-cross-process-propagation-headers-protocol-v3#extension-header-item)
Review comment:
```suggestion
Item** of SkyWalking Cross Process Propagation Headers Protocol v3](../../protocols/skywalking-cross-process-propagation-headers-protocol-v3.md#extension-header-item)
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/Service.java
##########
@@ -92,6 +91,6 @@ public String getEntityId() {
private TCPInfo tcpInfo = new TCPInfo();
public String getTag(String key) {
- return originalTags.getOrDefault(key, Const.EMPTY_STRING);
+ return originalTags.getOrDefault(key, null);
Review comment:
```suggestion
return originalTags.get(key);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [skywalking] kezhenxu94 commented on a change in pull request #7918: Message Queue performance and consuming latency monitoring
Posted by GitBox <gi...@apache.org>.
kezhenxu94 commented on a change in pull request #7918:
URL: https://github.com/apache/skywalking/pull/7918#discussion_r727901734
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/All.java
##########
@@ -73,6 +72,6 @@ public String getEntityId() {
private Map<String, String> originalTags;
public String getTag(String key) {
- return originalTags.getOrDefault(key, Const.EMPTY_STRING);
+ return originalTags.getOrDefault(key, null);
Review comment:
```suggestion
return originalTags.get(key);
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/Endpoint.java
##########
@@ -100,6 +99,6 @@ public void prepare() {
}
public String getTag(String key) {
- return originalTags.getOrDefault(key, Const.EMPTY_STRING);
+ return originalTags.getOrDefault(key, null);
Review comment:
```suggestion
return originalTags.get(key);
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/ServiceInstance.java
##########
@@ -102,6 +100,6 @@ public void prepare() {
}
public String getTag(String key) {
- return originalTags.getOrDefault(key, Const.EMPTY_STRING);
+ return originalTags.getOrDefault(key, null);
Review comment:
```suggestion
return originalTags.get(key);
```
##########
File path: docs/en/setup/backend/mq.md
##########
@@ -0,0 +1,14 @@
+# Message Queue performance and consuming latency monitoring
+
+Message Queue server plays an important role in today's distributed system, in order to reduce the length and latency of
+blocking RPC, and eventually improve user experience. But in this async way, the measure for queue consuming traffic and
+latency becomes significant.
+
+Since 8.9.0, SkyWalking leverages native tracing agent and [**Extension Header
+Item** of SkyWalking Cross Process Propagation Headers Protocol v3](../../protocols/skywalking-cross-process-propagation-headers-protocol-v3#extension-header-item)
Review comment:
```suggestion
Item** of SkyWalking Cross Process Propagation Headers Protocol v3](../../protocols/skywalking-cross-process-propagation-headers-protocol-v3.md#extension-header-item)
```
##########
File path: oap-server/server-core/src/main/java/org/apache/skywalking/oap/server/core/source/Service.java
##########
@@ -92,6 +91,6 @@ public String getEntityId() {
private TCPInfo tcpInfo = new TCPInfo();
public String getTag(String key) {
- return originalTags.getOrDefault(key, Const.EMPTY_STRING);
+ return originalTags.getOrDefault(key, null);
Review comment:
```suggestion
return originalTags.get(key);
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org