You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@uima.apache.org by Richard Eckart de Castilho <re...@apache.org> on 2020/04/19 15:53:07 UTC

[VOTE] Release UIMA uimaFIT 2.5.0 RC2

Hi,

I've posted the uimaFIT 2.5.0 release candidate 2.


uimaFIT 2.5.0 is a minor feature and bugfix release. On supported platforms, it should should serve
as a drop-in replacement for previous uimaFIT 2.x versions.

Changes since 2.5.0 RC1:

- UIMA-6222 - XML-related unit test fails on Java 9+
- UIMA-6223 - Groovy plugin causes warning during build
- UIMA-6224 - uimaFIT does not build on Java 14
- Without issue: commented out various print statements in unit tests to reduce log clutter during build

Changes:
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310570&version=12339544

The source and binary tar/zips are here:
https://dist.apache.org/repos/dist/dev/uima/uimafit/2.5.0-rc2/

The Maven artifacts are here:
https://repository.apache.org/content/repositories/orgapacheuima-1253

The GIT tag is here:
https://github.com/apache/uima-uimafit/tree/uimafit-2.5.0

Clone using: git clone -b uimafit-2.5.0 https://github.com/apache/uima-uimafit.git

See http://uima.apache.org/testing-builds.html for suggestions on how to test
release candidates.

Please vote on release:

[ ] +1 OK to release
[ ] 0   Don't care
[ ] -1 Not OK to release, because ...

Thanks.

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Richard Eckart de Castilho <re...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

* Build from sources zip (using Java 8): OK
* Build from sources zip (using Java 14): OK
* Checked README: OK
* Checked fixed issues: OK
* Checked API changes report: OK
* Compared git tag vs sources ZIP: OK
* Checked NOTICE and LICENSE files in the binary release: OK
  Note: there was an update of Spring which affected these

[X] +1 OK to release
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPY2MKJLmMo4NDQCrO8wPPFbjAA4FAl6ceBVfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNE
OEQ4QzI4OTJFNjMyOEUwRDBEMDBBQjNCQ0MwRjNDNTZFMzAwMEUACgkQO8wPPFbj
AA6TxA//STEo/KyVLbf/NV/IDUG1x5pk589JbynrCPm3LcBiT3mXKw3+N8ExMXAY
QvdBOikvOjXNNj/iWiBUGateUU3l5mAIP+mKsQsOa9PaQXRKy18IqTjZ4iIG0gVe
UdOPVN9Hk2WJwxvx1n8quME7EnyxZUPbLc2iCFr4E19aMbb36H/ATA58kdAPLLnw
a8/HddknUloblIHaBmw9Av4jFpE0+qf9j3QKGWRokuF5mEi/3HQJX/bUDZTOduoH
ht82PR4G4s9AmNSCyRF6IYe7W1ZbWjxt18LLHCSy9a3/yaq7/OII2d9/fufFTpc3
OOylt3nIUAgHo9KBWiioWjgW388eYSXsiu0+7KKAiG/UmGKTW9fcuEvF88w0Rmx7
Dt2NhnXkI4g7sih1XmO829tglVu7KItkUnPJEycsRTOeMP3Khx529jS+mZuSDcYD
zF+BBDxXgcFQgVT7yJOpgrg/OJEE8C/1o/6M6/rYfWfCaBXB2swYiKE0zbcKy/j1
xrXKfkeFByiBMJKIBAOQL01/SztN0u1ZQ5JxZTuOfPLJTiOrvnTstcpK0e6cbi+b
3j/KqOuwPOtY6fehEo8+YzKAMcqfTNtOPb7PoJ4YIj/AL2IRu3Xt+fkCj7w4UB8P
GL4QWTjm0KBjTdZFFFqK1aFdzoIyxhz6JLzUL0PhMBEiWpfU0Jg=
=H5f/
-----END PGP SIGNATURE-----


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2 - javadoc issues - not a blocker

Posted by Marshall Schor <ms...@schor.com>.
not a blocker:

[WARNING] Javadoc Warnings
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-core\src\main\java\org\apache\uima\fit\internal\ResourceManagerFactory.java:55:
warning: no @param for resourceManagerCreator
[WARNING] public static synchronized void setResourceManagerCreator(
[WARNING] ^


[WARNING] Javadoc Warnings
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-examples\src\main\java\org\apache\uima\fit\examples\resource\ExternalResourceExample.java:81:
warning: no @param for args
[WARNING] public static void main(String[] args) throws Exception {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-examples\src\main\java\org\apache\uima\fit\examples\resource\ExternalResourceExample.java:81:
warning: no @throws for java.lang.Exception
[WARNING] public static void main(String[] args) throws Exception {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-examples\src\main\java\org\apache\uima\fit\examples\resource\ExternalResourceExample2.java:82:
warning: no @param for args
[WARNING] public static void main(String[] args) throws Exception {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-examples\src\main\java\org\apache\uima\fit\examples\resource\ExternalResourceExample2.java:82:
warning: no @throws for java.lang.Exception
[WARNING] public static void main(String[] args) throws Exception {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-examples\src\main\java\org\apache\uima\fit\examples\resource\ExternalResourceExample3.java:72:
warning: no @param for args
[WARNING] public static void main(String[] args) throws Exception {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-examples\src\main\java\org\apache\uima\fit\examples\resource\ExternalResourceExample3.java:72:
warning: no @throws for java.lang.Exception
[WARNING] public static void main(String[] args) throws Exception {
[WARNING] ^


[WARNING] Javadoc Warnings
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-spring\src\main\java\org\apache\uima\fit\spring\util\ResourceInitializationUtil.java:36:
warning: no @param for <T>
[WARNING] public static <T> T initializeBean(AutowireCapableBeanFactory
aBeanFactory, T aBean, String aName) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-spring\src\main\java\org\apache\uima\fit\spring\util\ResourceInitializationUtil.java:36:
warning: no @param for aBeanFactory
[WARNING] public static <T> T initializeBean(AutowireCapableBeanFactory
aBeanFactory, T aBean, String aName) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-spring\src\main\java\org\apache\uima\fit\spring\util\ResourceInitializationUtil.java:36:
warning: no @param for aBean
[WARNING] public static <T> T initializeBean(AutowireCapableBeanFactory
aBeanFactory, T aBean, String aName) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-spring\src\main\java\org\apache\uima\fit\spring\util\ResourceInitializationUtil.java:36:
warning: no @param for aName
[WARNING] public static <T> T initializeBean(AutowireCapableBeanFactory
aBeanFactory, T aBean, String aName) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-spring\src\main\java\org\apache\uima\fit\spring\util\ResourceInitializationUtil.java:36:
warning: no @return
[WARNING] public static <T> T initializeBean(AutowireCapableBeanFactory
aBeanFactory, T aBean, String aName) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-spring\src\main\java\org\apache\uima\fit\spring\util\ResourceInitializationUtil.java:46:
warning: no @param for aResource
[WARNING] public static Resource initResource(Resource aResource,
ApplicationContext aApplicationContext) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-spring\src\main\java\org\apache\uima\fit\spring\util\ResourceInitializationUtil.java:46:
warning: no @param for aApplicationContext
[WARNING] public static Resource initResource(Resource aResource,
ApplicationContext aApplicationContext) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-spring\src\main\java\org\apache\uima\fit\spring\util\ResourceInitializationUtil.java:46:
warning: no @return
[WARNING] public static Resource initResource(Resource aResource,
ApplicationContext aApplicationContext) {
[WARNING] ^



[WARNING] Javadoc Warnings
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:116:
warning: no @param for aProject
[WARNING] public static String getClassName(MavenProject aProject, String aFile) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:116:
warning: no @param for aFile
[WARNING] public static String getClassName(MavenProject aProject, String aFile) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:116:
warning: no @return
[WARNING] public static String getClassName(MavenProject aProject, String aFile) {
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:126:
warning: no @param for aProject
[WARNING] public static URLClassLoader getClassloader(MavenProject aProject, Log
aLog)
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:126:
warning: no @param for aLog
[WARNING] public static URLClassLoader getClassloader(MavenProject aProject, Log
aLog)
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:126:
warning: no @return
[WARNING] public static URLClassLoader getClassloader(MavenProject aProject, Log
aLog)
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:126:
warning: no @throws for org.apache.maven.plugin.MojoExecutionException
[WARNING] public static URLClassLoader getClassloader(MavenProject aProject, Log
aLog)
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:173:
warning: no @param for aClass
[WARNING] public static ComponentType getType(ClassLoader aClassLoader, Class
aClass)
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:173:
warning: no @return
[WARNING] public static ComponentType getType(ClassLoader aClassLoader, Class
aClass)
[WARNING] ^
[WARNING]
C:\au\t\uimaFIT\2.5.0\rc2\uimafit-2.5.0-bfs\uimafit-maven-plugin\src\main\java\org\apache\uima\fit\maven\util\Util.java:173:
warning: no @throws for java.lang.ClassNotFoundException
[WARNING] public static ComponentType getType(ClassLoader aClassLoader, Class
aClass)

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Richard Eckart de Castilho <re...@apache.org>.
On 20. Apr 2020, at 19:54, Marshall Schor <ms...@schor.com> wrote:
> 
> The README has a section on "Modules".
> 
> It might be missing the entry for uimafit-benchmarks?

IMHO the benchmark module doesn't add anything for the user. I used it for a few cases during development. It is not general-purpose benchmarking code.

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Marshall Schor <ms...@schor.com>.
The README has a section on "Modules".

It might be missing the entry for uimafit-benchmarks?

-Marshall


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Marshall Schor <sc...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512
 

2.5.0 rc2:

signatures - OK
compare source-release with git tag: ok, noted Eclipse .settings file in git
build from sources with Java 14: OK
   some javadoc issues (warnings)
issues fixed: OK.
api change report: OK

Readme: OK.

Nice comments on how to contribute using GIT PULL etc.,
and pointer to github repo in the readme :-)

[x] +1 OK to release

Marshall Schor

On 4/19/2020 11:53 AM, Richard Eckart de Castilho wrote:
> Hi,
>
> I've posted the uimaFIT 2.5.0 release candidate 2.
>
>
> uimaFIT 2.5.0 is a minor feature and bugfix release. On supported platforms,
it should should serve
> as a drop-in replacement for previous uimaFIT 2.x versions.
>
> Changes since 2.5.0 RC1:
>
> - UIMA-6222 - XML-related unit test fails on Java 9+
> - UIMA-6223 - Groovy plugin causes warning during build
> - UIMA-6224 - uimaFIT does not build on Java 14
> - Without issue: commented out various print statements in unit tests to
reduce log clutter during build
>
> Changes:
>
https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310570&version=12339544
>
> The source and binary tar/zips are here:
> https://dist.apache.org/repos/dist/dev/uima/uimafit/2.5.0-rc2/
>
> The Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapacheuima-1253
>
> The GIT tag is here:
> https://github.com/apache/uima-uimafit/tree/uimafit-2.5.0
>
> Clone using: git clone -b uimafit-2.5.0 https://github.com/apache/uima-uimafit.git
>
> See http://uima.apache.org/testing-builds.html for suggestions on how to test
> release candidates.
>
> Please vote on release:
>
> [ ] +1 OK to release
> [ ] 0   Don't care
> [ ] -1 Not OK to release, because ...
>
> Thanks.
>
> -- Richard
-----BEGIN PGP SIGNATURE-----
 
iQIzBAEBCgAdFiEEOn/mVSh3S1eNEDz+zHYv/c0Ez9YFAl6h1C4ACgkQzHYv/c0E
z9Yn4BAAnVUM9xbwFzfOFREfOhm/jlHjbcGkahfLXhZRryO6Bfg4Gyae5fS2tT6S
EkPMDfPFcr4oZRgLmy0esKVgQcleVps0ToGjiIxcq4XRUp7/+EQE29iVCvEzT4Ps
G5T8pYFLC5q3jzcyYtb3XgKQNmcRn6MsczzRA2nRbtRxH9uK9wbIsAqeDqT2s8/y
2ElOyKKWeXMijH1XPpnq+WD/pTpzfgGwzDPyu9a4uOLyFt+07BXJNutJH9ny6601
JNwPIQgAnnJ4wFJPY1HW5oTFvJxLnPcswEm62afjwXA7sLkSmFEPeZJr0JLt7idH
xlkSiqOTtrArO/e3RoQ/WaRTKPfB9EQvFWGQeCVCKXvsPWKLj8LF1m/AmWAjB7rl
s+2Xhks3PpHgmhQuLHVjX7hjGgKXZje5QMlZ07mqpJMj0FQTTlniqA04y1l61xoi
cT3BCVBSj7HKa6b2Hj8S6bu4EHWR9+Wk20oQjTI0cyi7rNfhB9yzS5nnZ1oXroUz
Hk1ckdhPw3fCud5sl/BX2ciJrWBc/04ntsiFPbCgPBjMpTMm50/9LjmZMUTvIx2o
Yc3UaQh4+XM1h/D5PnXfoygvRMr3x74CAq+z3CWQPziNooP9EWefjqLvwNyVaq5C
a5ySE4/4/O2zJPjqgByvwi2gtTAmPdsN4wMfIncyA6GE49DxWyI=
=ursN
-----END PGP SIGNATURE-----


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Richard Eckart de Castilho <re...@apache.org>.
I was pointed to an issue with the uimaFIT Maven Plugin that we have since ... well, since forever. It is not able to resolve import-by-name in typesystem descriptors if the imported descriptor comes from a dependency and not from the module where the plugin is declared.

If I do not find a workaround, I'll probably cancel this vote, fix the issue and call for a new one...

I'll get back to you...

-- Richard


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Viorel Morari <vi...@averbis.com>.
Hi,

> Right, it fails in Eclipse. However, I don't see it as a priority that the build works in Eclipse as long as the CLI build works. We can open an issue if you like and maybe track it down at some point, but for the time being, I personally consider it as a "nice to have" thing that the Maven build also works in Eclipse (note: the unit tests work in Eclipse and it also compiles without errors in Eclipse - just the integration tests from a Maven build triggered within Eclipse fail).

No, that's fine, as long as that's intentional and aknowledged. I had UIMA Ruta as reference for review -- was expecting the same behaviour.


- Viorel


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Richard Eckart de Castilho <re...@apache.org>.
Hi Vio,

> On 22. Apr 2020, at 19:25, Viorel Morari <vi...@averbis.com> wrote:
> 
> .) Is see Spring Framework in use both in source- and bin-release. While the LICENSE file of the bin-realease mentions it, in the LICENSE of the source-release it is missing. No sure if that's intentional.

The binary release ZIP file includes the Spring JARs - that is why their license text is included.

The source release only compiles against Spring, but does not ship it. So the license text is not included.

> 2.) Building uimafit with Java 8 in Eclipse 2020-03 fails. The build fails in the maven-plugin module:
>    [INFO] Building: default\pom.xml
>    [INFO] run post-build script verify.bsh
>    [INFO]           default\pom.xml .................................. FAILED (0.1 s)
>    [INFO]   The post-build script returned false.
>    [INFO] Building: with-typesystem-in-descriptors\pom.xml
>    [INFO] run post-build script verify.bsh
>    [INFO]           with-typesystem-in-descriptors\pom.xml ........... FAILED (0.0 s)
>    [INFO]   The post-build script returned false.
> The build is successful in the console though. Don't know if that's an Eclipse related problem or if I'm missing something.

Right, it fails in Eclipse. However, I don't see it as a priority that the build works in Eclipse as long as the CLI build works. We can open an issue if you like and maybe track it down at some point, but for the time being, I personally consider it as a "nice to have" thing that the Maven build also works in Eclipse (note: the unit tests work in Eclipse and it also compiles without errors in Eclipse - just the integration tests from a Maven build triggered within Eclipse fail).

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Viorel Morari <vi...@averbis.com>.
Hello,

Two questions/remarks I'd like to clarify:

1.) Is see Spring Framework in use both in source- and bin-release. While the LICENSE file of the bin-realease mentions it, in the LICENSE of the source-release it is missing. No sure if that's intentional.

2.) Building uimafit with Java 8 in Eclipse 2020-03 fails. The build fails in the maven-plugin module:
     [INFO] Building: default\pom.xml
     [INFO] run post-build script verify.bsh
     [INFO]           default\pom.xml .................................. FAILED (0.1 s)
     [INFO]   The post-build script returned false.
     [INFO] Building: with-typesystem-in-descriptors\pom.xml
     [INFO] run post-build script verify.bsh
     [INFO]           with-typesystem-in-descriptors\pom.xml ........... FAILED (0.0 s)
     [INFO]   The post-build script returned false.
  
The build is successful in the console though. Don't know if that's an Eclipse related problem or if I'm missing something.


- Viorel

Am 19.04.2020 um 17:53 schrieb Richard Eckart de Castilho:
> Hi,
>
> I've posted the uimaFIT 2.5.0 release candidate 2.
>
>
> uimaFIT 2.5.0 is a minor feature and bugfix release. On supported platforms, it should should serve
> as a drop-in replacement for previous uimaFIT 2.x versions.
>
> Changes since 2.5.0 RC1:
>
> - UIMA-6222 - XML-related unit test fails on Java 9+
> - UIMA-6223 - Groovy plugin causes warning during build
> - UIMA-6224 - uimaFIT does not build on Java 14
> - Without issue: commented out various print statements in unit tests to reduce log clutter during build
>
> Changes:
> https://issues.apache.org/jira/secure/ReleaseNote.jspa?projectId=12310570&version=12339544
>
> The source and binary tar/zips are here:
> https://dist.apache.org/repos/dist/dev/uima/uimafit/2.5.0-rc2/
>
> The Maven artifacts are here:
> https://repository.apache.org/content/repositories/orgapacheuima-1253
>
> The GIT tag is here:
> https://github.com/apache/uima-uimafit/tree/uimafit-2.5.0
>
> Clone using: git clone -b uimafit-2.5.0 https://github.com/apache/uima-uimafit.git
>
> See http://uima.apache.org/testing-builds.html for suggestions on how to test
> release candidates.
>
> Please vote on release:
>
> [ ] +1 OK to release
> [ ] 0   Don't care
> [ ] -1 Not OK to release, because ...
>
> Thanks.
>
> -- Richard

-- 
Viorel Morari
R&D Text Mining/Machine Learning

Averbis GmbH
Salzstr. 15
79098 Freiburg
Germany

Fon: +49 761 708 394 0
Fax: +49 761 708 394 10
Email: viorel.morari@averbis.com
Web: https://averbis.com

Headquarters: Freiburg im Breisgau
Register Court: Amtsgericht Freiburg im Breisgau, HRB 701080
Managing Directors: Dr. med. Philipp Daumke, Dr. Kornél Markó


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Richard Eckart de Castilho <re...@apache.org>.
On 20. Apr 2020, at 16:32, Marshall Schor <ms...@schor.com> wrote:
> 
> When building for the 1st time from sources, my maven system downloaded from central
> both:
>   Downloaded from mirror-central: ...
> org/codehaus/groovy/groovy-all/2.4.9/groovy-all-2.4.9.jar (7.0 MB at 482 kB/s)
>   Downloaded from mirror-central: ...
> org/codehaus/groovy/groovy/3.0.3/groovy-3.0.3.jar (7.9 MB at 409 kB/s)
> 
> I kind of thought you had switched to 3.0.3, and was suprised to see there was
> some dependency on the 2.4.9 jar somewhere.

I did override the groovy dependency of the groovy maven plugin with the 3.x version, yes.

Not sure how exactly Maven resolves its plugin dependencies - but I have seen such effects
that older versions are unexpectedly downloaded during elsewhere as well. But considering
that the build works, that the old artifacts are still available and that minimizing the
build dependency footprint is presently not an objective, I ignore such things for the time
being.

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Marshall Schor <ms...@schor.com>.
This is probably ignorable:

When building for the 1st time from sources, my maven system downloaded from central
both:
  Downloaded from mirror-central: ...
org/codehaus/groovy/groovy-all/2.4.9/groovy-all-2.4.9.jar (7.0 MB at 482 kB/s)
  Downloaded from mirror-central: ...
org/codehaus/groovy/groovy/3.0.3/groovy-3.0.3.jar (7.9 MB at 409 kB/s)

I kind of thought you had switched to 3.0.3, and was suprised to see there was
some dependency on the 2.4.9 jar somewhere.

-Marshall


[RESULT][VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Richard Eckart de Castilho <re...@apache.org>.
-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA512

The vote passes, with 3 +1 votes and no other votes received.

+1 Richard Eckart de Castilho

+1 Marshall Schor

+1 Viorel Morari

Thanks for the reviews and votes!
-----BEGIN PGP SIGNATURE-----

iQKTBAEBCgB9FiEEPY2MKJLmMo4NDQCrO8wPPFbjAA4FAl6lcGlfFIAAAAAALgAo
aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNE
OEQ4QzI4OTJFNjMyOEUwRDBEMDBBQjNCQ0MwRjNDNTZFMzAwMEUACgkQO8wPPFbj
AA47Fg/+IwUoU9963kU5LzI9tYPtqkYm4gJhCTnyXmsaGkryjSKcRxCX6K0ncPgq
Kde/mxYrjJq9veYeRnLk9g4JgJXzfDEU35ZXLI+d7e+DkcISmgXQydJ9y6/ayGTs
QCYPRM4M7NL+cir742OEkLl4yL15If86kIhEK/u3XanVLivO0mX67CcAQp9Hs//m
bvPBQN8u7jsys11YoNJ6DAQ7+muUNnpOHyXb3eUkkFCrv7b5lTWh3sSKZrr0Ipgy
FjRE2maEG1w+9hzzAV4Sv3BkqfuRAnajG6lAclnPZlumXCpzch5oi2fLnWncrov0
ExCT4FlAp8zeF841x6NbfcedmXtEE6ufCoF35yz3e59fM7KRpy7+Bn2hP15U9eN8
9xNdY2YC+z2vRbyG0TVooD9QaGKXoq8H23367wdixUj5rImFoITMEvfaMyVzqZYJ
mjuX5aYCvQueii8OX0vMTNJ8dtlyanB8sgdzWf+3W+ViRUBzf6fhbe1ux3HCvjnk
/reCAerEyF4Wo8RUP3L2XAWqJNr6x3iPYIFvLD1MHWYng51IrjqVo97picPnd327
3kTn5gKkk+JPpLaFtwaLYsCyMha9UCENCftnrzR1M9/c3Gy/8n9NoqZte+xGds6H
7gh5JDMYLSsnHfwPSZfqVqfNzJ4yGHqQmsYsRa/5wKUELtfGXGc=
=KBd/
-----END PGP SIGNATURE-----


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Viorel Morari <vi...@averbis.com>.
Hi,

compared SVN tag with source-release ............................. OK
deleted .m2 built files, built from source ....................... OK
spot check DEPENDENCIES .......................................... OK
spot check LICENSE/NOTICE/README ................................. OK
build in Eclipse 2020_03 fails, but not a blocker ................ OK
check parent-pom settings for API compatibility .................. OK
documentation, couldn't find any description of the
new methods, e.g. CasUtil.exists(...).
Not a blocker, as documentation appears
to be minimal and the signature speaks for itself ................ OK
  

[X] +1 OK to release


-Viorel


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Richard Eckart de Castilho <re...@apache.org>.
On 20. Apr 2020, at 19:43, Marshall Schor <ms...@schor.com> wrote:
> 
> along these same lines, I see the sources include
> 
>     uimafit-spring
>     uimafit-legacy-support
>     uimafit-examples
>     uimafit-benchmark
> 
> that are not in the binary distribution.
> 
> Should any of these be part of the binary?

The "uimafit-legacy-support" is in the binary ZIP, but in the "extras" folder along with the CPE stuff.

The others are intentionally left out from the binary distribution.

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Marshall Schor <ms...@schor.com>.
I see that uimafit-spring in the README is described as
experimental, and intentionally excluded from the binary.

-M

On 4/20/2020 1:43 PM, Marshall Schor wrote:
> along these same lines, I see the sources include
>
>     uimafit-spring
>     uimafit-legacy-support
>     uimafit-examples
>     uimafit-benchmark
>
> that are not in the binary distribution.
>
> Should any of these be part of the binary?
>
> -Marshall
>
> On 4/20/2020 1:24 PM, Marshall Schor wrote:
>> The REAME says:
>>
>>     For your convenience, the binary
>>     distribution package of uimaFIT includes
>>     all libraries necessary to use uimaFIT.
>>
>> But the next sentence implies this isn't quite true:
>>
>>     In particular for novice users, it is strongly    
>>     advised to obtain a copy of the full UIMA SDK separately.
>>
>> --------------------------
>>
>> I see the binary has a lib which has uimaj-core.
>> I recall that uimaFIT has some components related to the CPE? (uimaFIT-cpe)
>>     Does this require the uimaj-cpe jar? If so, was it your intent
>>     that this jar be included in the binary distr?
>>
>> -Marshall
>>
>>

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Marshall Schor <ms...@schor.com>.
along these same lines, I see the sources include

    uimafit-spring
    uimafit-legacy-support
    uimafit-examples
    uimafit-benchmark

that are not in the binary distribution.

Should any of these be part of the binary?

-Marshall

On 4/20/2020 1:24 PM, Marshall Schor wrote:
> The REAME says:
>
>     For your convenience, the binary
>     distribution package of uimaFIT includes
>     all libraries necessary to use uimaFIT.
>
> But the next sentence implies this isn't quite true:
>
>     In particular for novice users, it is strongly    
>     advised to obtain a copy of the full UIMA SDK separately.
>
> --------------------------
>
> I see the binary has a lib which has uimaj-core.
> I recall that uimaFIT has some components related to the CPE? (uimaFIT-cpe)
>     Does this require the uimaj-cpe jar? If so, was it your intent
>     that this jar be included in the binary distr?
>
> -Marshall
>
>

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Richard Eckart de Castilho <re...@apache.org>.
On 20. Apr 2020, at 19:24, Marshall Schor <ms...@schor.com> wrote:
> 
> I recall that uimaFIT has some components related to the CPE? (uimaFIT-cpe)
>     Does this require the uimaj-cpe jar? If so, was it your intent
>     that this jar be included in the binary distr?

It is there in the "extras" folder.

-- Richard

Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Marshall Schor <ms...@schor.com>.
not a blocker, I think:

README says:

uimaFIT requires Java 1.8 or higher, UIMA 2.10.4 or higher,

but might want to say

uimaFIT requires Java 1.8 or higher, UIMA 2.10.4 or higher but less that UIMA 3.0.0,

(or figure out some better wording...) :-)

-Marshall


Re: [VOTE] Release UIMA uimaFIT 2.5.0 RC2

Posted by Marshall Schor <ms...@schor.com>.
The REAME says:

    For your convenience, the binary
    distribution package of uimaFIT includes
    all libraries necessary to use uimaFIT.

But the next sentence implies this isn't quite true:

    In particular for novice users, it is strongly    
    advised to obtain a copy of the full UIMA SDK separately.

--------------------------

I see the binary has a lib which has uimaj-core.
I recall that uimaFIT has some components related to the CPE? (uimaFIT-cpe)
    Does this require the uimaj-cpe jar? If so, was it your intent
    that this jar be included in the binary distr?

-Marshall