You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@activemq.apache.org by iweiss <gi...@git.apache.org> on 2016/04/13 13:43:30 UTC
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
GitHub user iweiss opened a pull request:
https://github.com/apache/activemq-artemis/pull/459
ARTEMIS-480 BridgeReconnectTest.testDeliveringCountOnBridgeConnection…
…Failure fails due to racing condition
Signed-off-by: Ingo Weiss <in...@redhat.com>
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/iweiss/activemq-artemis master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/activemq-artemis/pull/459.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #459
----
commit 231ef0b8c17a345301ae0a3112e1e50d035eac5e
Author: Ingo Weiss <in...@redhat.com>
Date: 2016-04-13T11:42:38Z
ARTEMIS-480 BridgeReconnectTest.testDeliveringCountOnBridgeConnectionFailure fails due to racing condition
Signed-off-by: Ingo Weiss <in...@redhat.com>
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-211597652
please rebase your branch and push -f after rebased.. there's 2 merge committs on your branch what would be quite bad if someone merged this by accident.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-209441882
can you please amend your commit and remove the comment about the sign of?
You already have your git commit authorship.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/activemq-artemis/pull/459
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-211598653
I actually did it myself through an intermediate branch... nice job on finding this one.. thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-209450621
I don't think the change is right anyways...
incDelivering is called only after handled...
The testcase is playing with cancellations and crashes. Perhaps there's a situation where the decDelivering should be called (after some specific crash or something).. but that would be a corner case.
Having this fix here might fix the testcase but break other production cases. Needs an overall thinking
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-209445854
actually.. it's messy...
you should have ammended the commit and push -f y our repo.. you have 4 commits for this including a merge branch commit
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by iweiss <gi...@git.apache.org>.
Github user iweiss commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-209451134
Done. 1 commit. Sorry about the trouble.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by iweiss <gi...@git.apache.org>.
Github user iweiss commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-211269832
retest this please
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by clebertsuconic <gi...@git.apache.org>.
Github user clebertsuconic commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-209446943
Leave it with me, I will fix it during merge
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by iweiss <gi...@git.apache.org>.
Github user iweiss commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-211403133
Something's off with the latest Jenkins validation. It seems to have finished and succeeded.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] activemq-artemis pull request: ARTEMIS-480 BridgeReconnectTest.tes...
Posted by iweiss <gi...@git.apache.org>.
Github user iweiss commented on the pull request:
https://github.com/apache/activemq-artemis/pull/459#issuecomment-209445506
Should be OK now
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---