You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@rocketmq.apache.org by GitBox <gi...@apache.org> on 2020/08/19 06:32:22 UTC

[GitHub] [rocketmq] imaffe commented on a change in pull request #2254: [ISSUE #2237]Fix the issue#2237 The confuse logic of removing the timeout ResponseFuture

imaffe commented on a change in pull request #2254:
URL: https://github.com/apache/rocketmq/pull/2254#discussion_r472758500



##########
File path: remoting/src/main/java/org/apache/rocketmq/remoting/netty/NettyRemotingAbstract.java
##########
@@ -381,7 +380,6 @@ protected RPCHook getRPCHook() {
      * </p>
      */
     public void scanResponseTable() {
-        final List<ResponseFuture> rfList = new LinkedList<ResponseFuture>();

Review comment:
       Why do we remove the executeInvokeCallback() method here ? If it timesout doesn't mean it should't execute InvokeCallback. Because timeout is also a form of completion,.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org