You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@uniffle.apache.org by GitBox <gi...@apache.org> on 2022/08/12 08:35:48 UTC
[GitHub] [incubator-uniffle] jerqi commented on a diff in pull request #156: [Improvement] Filter null value when selecting remote storage in ApplicationManager
jerqi commented on code in PR #156:
URL: https://github.com/apache/incubator-uniffle/pull/156#discussion_r944238883
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/ApplicationManagerTest.java:
##########
@@ -98,6 +98,24 @@ public void refreshTest() {
assertFalse(applicationManager.hasErrorInStatusCheck());
}
+ @Test
+ public void pickRemoteStorageTest() {
+ String remoteStoragePath = remotePath1 + Constants.COMMA_SPLIT_CHAR + remotePath2;
Review Comment:
Why do you add the case `pickRemoteStorageTest`
##########
coordinator/src/test/java/org/apache/uniffle/coordinator/ApplicationManagerTest.java:
##########
@@ -98,6 +98,24 @@ public void refreshTest() {
assertFalse(applicationManager.hasErrorInStatusCheck());
}
+ @Test
+ public void pickRemoteStorageTest() {
+ String remoteStoragePath = remotePath1 + Constants.COMMA_SPLIT_CHAR + remotePath2;
Review Comment:
Why do you add the case `pickRemoteStorageTest`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@uniffle.apache.org
For additional commands, e-mail: issues-help@uniffle.apache.org