You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Ben Mahler <be...@gmail.com> on 2012/12/07 00:44:23 UTC
Review Request: Fixed parsing of /proc/cpuinfo when the physical and core
ids are not present.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8388/
-----------------------------------------------------------
Review request for mesos, Benjamin Hindman and Vinod Kone.
Description
-------
See above. Here's an example cpuinfo from my VM (where physical id and core id are not present):
processor : 0
vendor_id : GenuineIntel
cpu family : 6
model : 58
model name : Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz
stepping : 9
microcode : 0x15
cpu MHz : 2891.326
cache size : 4096 KB
fpu : yes
fpu_exception : yes
cpuid level : 13
wp : yes
flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts mmx fxsr sse sse2 ss syscall nx rdtscp lm constant_tsc up arch_perfmon pebs bts nopl xtopology tsc_reliable nonstop_tsc aperfmperf pni pclmulqdq ssse3 cx16 pcid sse4_1 sse4_2 x2apic popcnt aes xsave avx f16c rdrand hypervisor lahf_lm ida arat epb xsaveopt pln pts dtherm fsgsbase smep
bogomips : 5782.65
clflush size : 64
cache_alignment : 64
address sizes : 40 bits physical, 48 bits virtual
power management:
Diffs
-----
src/linux/proc.cpp 99df77447ddfb07a5febec9ebfed396778665041
Diff: https://reviews.apache.org/r/8388/diff/
Testing
-------
make check, this unbreaks ProcTest.Cpus
Thanks,
Ben Mahler
Re: Review Request: Fixed parsing of /proc/cpuinfo when the physical and
core ids are not present.
Posted by Benjamin Hindman <be...@berkeley.edu>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/8388/#review14325
-----------------------------------------------------------
Ship it!
Ship It!
- Benjamin Hindman
On Dec. 6, 2012, 11:44 p.m., Ben Mahler wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/8388/
> -----------------------------------------------------------
>
> (Updated Dec. 6, 2012, 11:44 p.m.)
>
>
> Review request for mesos, Benjamin Hindman and Vinod Kone.
>
>
> Description
> -------
>
> See above. Here's an example cpuinfo from my VM (where physical id and core id are not present):
>
> processor : 0
> vendor_id : GenuineIntel
> cpu family : 6
> model : 58
> model name : Intel(R) Core(TM) i7-3520M CPU @ 2.90GHz
> stepping : 9
> microcode : 0x15
> cpu MHz : 2891.326
> cache size : 4096 KB
> fpu : yes
> fpu_exception : yes
> cpuid level : 13
> wp : yes
> flags : fpu vme de pse tsc msr pae mce cx8 apic sep mtrr pge mca cmov pat pse36 clflush dts mmx fxsr sse sse2 ss syscall nx rdtscp lm constant_tsc up arch_perfmon pebs bts nopl xtopology tsc_reliable nonstop_tsc aperfmperf pni pclmulqdq ssse3 cx16 pcid sse4_1 sse4_2 x2apic popcnt aes xsave avx f16c rdrand hypervisor lahf_lm ida arat epb xsaveopt pln pts dtherm fsgsbase smep
> bogomips : 5782.65
> clflush size : 64
> cache_alignment : 64
> address sizes : 40 bits physical, 48 bits virtual
> power management:
>
>
> Diffs
> -----
>
> src/linux/proc.cpp 99df77447ddfb07a5febec9ebfed396778665041
>
> Diff: https://reviews.apache.org/r/8388/diff/
>
>
> Testing
> -------
>
> make check, this unbreaks ProcTest.Cpus
>
>
> Thanks,
>
> Ben Mahler
>
>