You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@maven.apache.org by "cstamas (via GitHub)" <gi...@apache.org> on 2023/02/27 13:45:48 UTC
[GitHub] [maven] cstamas opened a new pull request, #1018: [MNH-7713] Drop legacy-local-repository option
cstamas opened a new pull request, #1018:
URL: https://github.com/apache/maven/pull/1018
There is really no need for it, and there is a resolver option if really must (but really should not, local repo is and should be considered as transient).
---
https://issues.apache.org/jira/browse/MNG-7713
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas merged pull request #1018: [maven-3.9.x] [MNG-7713] Drop legacy-local-repository option
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas merged PR #1018:
URL: https://github.com/apache/maven/pull/1018
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] cstamas commented on a diff in pull request #1018: [MNG-7713] Drop legacy-local-repository option
Posted by "cstamas (via GitHub)" <gi...@apache.org>.
cstamas commented on code in PR #1018:
URL: https://github.com/apache/maven/pull/1018#discussion_r1120742965
##########
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##########
@@ -256,8 +256,7 @@ public CLIManager() {
.build());
options.addOption(Option.builder(LEGACY_LOCAL_REPOSITORY)
.longOpt("legacy-local-repository")
- .desc(
- "Use Maven 2 Legacy Local Repository behaviour, ie no use of _remote.repositories. Can also be activated by using -Dmaven.legacyLocalRepo=true")
+ .desc("Ineffective, only kept for backward compatibility.")
Review Comment:
Agreed, i was drawn by other left defunct options...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] slawekjaranowski commented on a diff in pull request #1018: [MNG-7713] Drop legacy-local-repository option
Posted by "slawekjaranowski (via GitHub)" <gi...@apache.org>.
slawekjaranowski commented on code in PR #1018:
URL: https://github.com/apache/maven/pull/1018#discussion_r1120679215
##########
maven-embedder/src/main/java/org/apache/maven/cli/CLIManager.java:
##########
@@ -256,8 +256,7 @@ public CLIManager() {
.build());
options.addOption(Option.builder(LEGACY_LOCAL_REPOSITORY)
.longOpt("legacy-local-repository")
- .desc(
- "Use Maven 2 Legacy Local Repository behaviour, ie no use of _remote.repositories. Can also be activated by using -Dmaven.legacyLocalRepo=true")
+ .desc("Ineffective, only kept for backward compatibility.")
Review Comment:
If such option will have no effect - why we want to preserve it ...
If user use it - it will not works as user expect - so we will have silently different behavior that user think
For me will be better to drop at all - it will more clear for user and do not make confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [maven] anatolVasin commented on pull request #1018: [maven-3.9.x] [MNG-7713] Drop legacy-local-repository option
Posted by "anatolVasin (via GitHub)" <gi...@apache.org>.
anatolVasin commented on PR #1018:
URL: https://github.com/apache/maven/pull/1018#issuecomment-1499458903
> resolver option
Hello @cstamas , could you clarify what particular resolver option do you mean? Thanks.
Such capabilities really requires for emulate closed environments without access to Maven Central in tests.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@maven.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org