You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by "Maksym Bohachov (Jira)" <ji...@apache.org> on 2022/08/19 20:40:00 UTC
[jira] [Comment Edited] (MATH-1647) HaltonSequenceGenerator.skipTo() not throwing proper NotPositiveException
[ https://issues.apache.org/jira/browse/MATH-1647?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17581986#comment-17581986 ]
Maksym Bohachov edited comment on MATH-1647 at 8/19/22 8:39 PM:
----------------------------------------------------------------
Hi, there is PR to fix issue with appropriate unit test.
https://github.com/apache/commons-math/pull/211
was (Author: JIRAUSER294665):
Hi, there is PR to fix issue with appropriate unit test.
> HaltonSequenceGenerator.skipTo() not throwing proper NotPositiveException
> -------------------------------------------------------------------------
>
> Key: MATH-1647
> URL: https://issues.apache.org/jira/browse/MATH-1647
> Project: Commons Math
> Issue Type: Bug
> Affects Versions: 3.6.1
> Reporter: Elia Bertolina
> Priority: Major
> Fix For: 4.0
>
> Time Spent: 20m
> Remaining Estimate: 0h
>
> HaltonSequenceGenerator.skipTo(int index) does not throw a NotPositiveException when the parameter is negative.In the documentation it is stated that an NotPositiveException will be thrown if the parameter value is less than zero.
> However, in this test case:
> {code:java}
> public class HaltonSequenceGenerator_Test{
> public void test() throws Throwable{
> HaltonSequenceGenerator haltonSequenceGenerator = new
> HaltonSequenceGenerator(1);
> try {
> double[] doubleArray =
> haltonSequenceGenerator.skipTo((-4584));
> org.junit.Assert.fail();
> } catch
> (org.apache.commons.math3.exception.NotPositiveException e){
> //NotPositiveException caught and test successful
> }
> }
> } {code}
> The int parameter is negative and a NotPositiveException should be thrown, however the method executes normally, and test case fails.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)