You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@iceberg.apache.org by "kevinjqliu (via GitHub)" <gi...@apache.org> on 2024/11/27 22:26:49 UTC
[PR] [infra] Prevent running `python-release` action without specifying rc version [iceberg-python]
kevinjqliu opened a new pull request, #1386:
URL: https://github.com/apache/iceberg-python/pull/1386
When running without RC version, artifacts will be published to PyPi as the "official version", which is not what we want.
Let's always run with RC version or as main to prevent accidentally pushing new official versions to PyPi.
When the RC passes, releasing as the official version downloads artifacts from SVN
https://github.com/apache/iceberg-python/blob/main/mkdocs/docs/how-to-release.md#upload-the-accepted-release-to-pypi
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] Prevent running `python-release` action without a specified rc version [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu closed pull request #1386: [infra] Prevent running `python-release` action without a specified rc version
URL: https://github.com/apache/iceberg-python/pull/1386
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] Prevent running `python-release` action without a specified rc version [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on PR #1386:
URL: https://github.com/apache/iceberg-python/pull/1386#issuecomment-2518328627
closing in favor of #1391
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org
Re: [PR] [infra] Prevent running `python-release` action without a specified rc version [iceberg-python]
Posted by "kevinjqliu (via GitHub)" <gi...@apache.org>.
kevinjqliu commented on code in PR #1386:
URL: https://github.com/apache/iceberg-python/pull/1386#discussion_r1861373849
##########
.github/workflows/python-release.yml:
##########
@@ -29,12 +29,30 @@ on:
jobs:
+ validate_version:
+ name: Validate version input
+ runs-on: ubuntu-latest
+ steps:
+ - name: Echo version input
+ run: |
+ echo "Version input is: ${{ github.event.inputs.version }}"
+
+ - name: Validate version input
+ if: ${{ github.event.inputs.version != 'main' && !contains(github.event.inputs.version, 'rc') }}
Review Comment:
had to do this since we run on different os environments with different shells
##########
.github/workflows/python-release.yml:
##########
@@ -29,12 +29,30 @@ on:
jobs:
+ validate_version:
+ name: Validate version input
+ runs-on: ubuntu-latest
+ steps:
+ - name: Echo version input
+ run: |
+ echo "Version input is: ${{ github.event.inputs.version }}"
+
+ - name: Validate version input
+ if: ${{ github.event.inputs.version != 'main' && !contains(github.event.inputs.version, 'rc') }}
Review Comment:
had to do this since we run on different os environments with different default shells
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org