You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hive.apache.org by Ashish Singh <as...@cloudera.com> on 2014/07/03 05:38:19 UTC
Review Request 23256: HIVE-7345: Beeline changes its prompt to reflect
successful database connection even after failing to connect
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23256/
-----------------------------------------------------------
Review request for hive.
Bugs: HIVE-7345
https://issues.apache.org/jira/browse/HIVE-7345
Repository: hive-git
Description
-------
HIVE-7345: Beeline changes its prompt to reflect successful database connection even after failing to connect
Diffs
-----
beeline/src/java/org/apache/hive/beeline/BeeLine.java 2f3350e79f6168b11c13c6b4f84128c9255e0383
beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 00b49afb72531a4c15d0239ba08b04faa229d262
Diff: https://reviews.apache.org/r/23256/diff/
Testing
-------
NA
Thanks,
Ashish Singh
Re: Review Request 23256: HIVE-7345: Beeline changes its prompt to reflect
successful database connection even after failing to connect
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23256/#review47332
-----------------------------------------------------------
Ship it!
Ship It!
- Navis Ryu
On July 3, 2014, 3:38 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23256/
> -----------------------------------------------------------
>
> (Updated July 3, 2014, 3:38 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7345
> https://issues.apache.org/jira/browse/HIVE-7345
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7345: Beeline changes its prompt to reflect successful database connection even after failing to connect
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 2f3350e79f6168b11c13c6b4f84128c9255e0383
> beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 00b49afb72531a4c15d0239ba08b04faa229d262
>
> Diff: https://reviews.apache.org/r/23256/diff/
>
>
> Testing
> -------
>
> NA
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 23256: HIVE-7345: Beeline changes its prompt to reflect
successful database connection even after failing to connect
Posted by Navis Ryu <na...@nexr.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23256/#review47703
-----------------------------------------------------------
Ship it!
Ship It!
- Navis Ryu
On July 14, 2014, 1:15 a.m., Ashish Singh wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/23256/
> -----------------------------------------------------------
>
> (Updated July 14, 2014, 1:15 a.m.)
>
>
> Review request for hive.
>
>
> Bugs: HIVE-7345
> https://issues.apache.org/jira/browse/HIVE-7345
>
>
> Repository: hive-git
>
>
> Description
> -------
>
> HIVE-7345: Beeline changes its prompt to reflect successful database connection even after failing to connect
>
>
> Diffs
> -----
>
> beeline/src/java/org/apache/hive/beeline/BeeLine.java 2f3350e79f6168b11c13c6b4f84128c9255e0383
> beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 00b49afb72531a4c15d0239ba08b04faa229d262
>
> Diff: https://reviews.apache.org/r/23256/diff/
>
>
> Testing
> -------
>
> NA
>
>
> Thanks,
>
> Ashish Singh
>
>
Re: Review Request 23256: HIVE-7345: Beeline changes its prompt to reflect
successful database connection even after failing to connect
Posted by Ashish Singh <as...@cloudera.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/23256/
-----------------------------------------------------------
(Updated July 14, 2014, 1:15 a.m.)
Review request for hive.
Changes
-------
Address review comment from JIRA.
Bugs: HIVE-7345
https://issues.apache.org/jira/browse/HIVE-7345
Repository: hive-git
Description
-------
HIVE-7345: Beeline changes its prompt to reflect successful database connection even after failing to connect
Diffs (updated)
-----
beeline/src/java/org/apache/hive/beeline/BeeLine.java 2f3350e79f6168b11c13c6b4f84128c9255e0383
beeline/src/java/org/apache/hive/beeline/DatabaseConnection.java 00b49afb72531a4c15d0239ba08b04faa229d262
Diff: https://reviews.apache.org/r/23256/diff/
Testing
-------
NA
Thanks,
Ashish Singh