You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@bahir.apache.org by ScrapCodes <gi...@git.apache.org> on 2016/08/11 10:28:29 UTC
[GitHub] bahir pull request #22: [BAHIR-51] MqttStreamSource supports a few important...
GitHub user ScrapCodes opened a pull request:
https://github.com/apache/bahir/pull/22
[BAHIR-51] MqttStreamSource supports a few important MqttConnectOptions.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/ScrapCodes/bahir BAHIR-51
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/bahir/pull/22.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #22
----
commit de08f208454f9a96381d5fac90afb4d33b6ef352
Author: Prashant Sharma <pr...@in.ibm.com>
Date: 2016-08-11T10:26:20Z
[BAHIR-51] MqttStreamSource supports a few important MqttConnectOptions.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #22: [BAHIR-51] MqttStreamSource supports a few important MqttCo...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/22
Would these also apply to the DStream MQTT extension ? if so, should we try to maintain the same level of MQTT supported functionality between the two ?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #22: [BAHIR-51] MqttStreamSource supports a few important MqttCo...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/22
Never mind, #23 is taking care of these changes on the DStream MQTT extension.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #22: [BAHIR-51] MqttStreamSource supports a few important MqttCo...
Posted by lresende <gi...@git.apache.org>.
Github user lresende commented on the issue:
https://github.com/apache/bahir/pull/22
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir pull request #22: [BAHIR-51] MqttStreamSource supports a few important...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/bahir/pull/22
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #22: [BAHIR-51] MqttStreamSource supports a few important MqttCo...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the issue:
https://github.com/apache/bahir/pull/22
Thanks @swoehrl-mw, @lresende Please take a look !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #22: [BAHIR-51] MqttStreamSource supports a few important MqttCo...
Posted by ScrapCodes <gi...@git.apache.org>.
Github user ScrapCodes commented on the issue:
https://github.com/apache/bahir/pull/22
Thanks Luciano !
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] bahir issue #22: [BAHIR-51] MqttStreamSource supports a few important MqttCo...
Posted by swoehrl-mw <gi...@git.apache.org>.
Github user swoehrl-mw commented on the issue:
https://github.com/apache/bahir/pull/22
Change looks good to me. It adds all the important mqtt options and uses sensible defaults.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---