[GitHub] [knox] smolnar82 commented on a change in pull request #487: KNOX-2651 - NPE when token value is missing

[GitBox <gi...@apache.org>]

smolnar82 commented on a change in pull request #487:
URL: https://github.com/apache/knox/pull/487#discussion_r698725448



##########
File path: gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTFederationFilter.java
##########
@@ -126,7 +126,7 @@ public void doFilter(ServletRequest request, ServletResponse response, FilterCha
     }
     final Pair<TokenType, String> wireToken = getWireToken(request);
 
-    if (wireToken != null) {
+    if (wireToken != null && wireToken.getLeft() != null && wireToken.getRight() != null) {

Review comment:
       I think we could log the fact that token type/value is missing. It'd be a great help when debugging 401 issues.




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@knox.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org