You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/09/14 14:47:05 UTC

[GitHub] [superset] etr2460 commented on a change in pull request #16701: chore: Upgrade Webpack to v5

etr2460 commented on a change in pull request #16701:
URL: https://github.com/apache/superset/pull/16701#discussion_r708347175



##########
File path: superset-frontend/webpack.config.js
##########
@@ -268,13 +264,7 @@ const config = {
             ].join('|')})/`,
           ),
         },
-        // bundle large libraries separately
-        mathjs: {
-          name: 'mathjs',
-          test: /\/node_modules\/mathjs\//,
-          priority: 30,
-          enforce: true,
-        },
+        // // bundle large libraries separately

Review comment:
       i think we can delete this line?

##########
File path: superset-frontend/package.json
##########
@@ -129,7 +129,7 @@
     "lodash": "^4.17.21",
     "lodash-es": "^4.17.21",
     "match-sorter": "^6.1.0",
-    "mathjs": "^8.0.1",

Review comment:
       this will be a great perf win too!




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org