You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2021/05/25 03:17:33 UTC

[GitHub] [druid] suneet-s edited a comment on pull request #11283: chill, travis

suneet-s edited a comment on pull request #11283:
URL: https://github.com/apache/druid/pull/11283#issuecomment-847496965


   @clintropolis can you push a few more commits to your test PRs to show what happens when there are multiple commits in a PR. Once these tests do what we expect, I'm LGTM.
   
   A doc update somewhere to explain which tests are expected to run in what scenarios would be a nice to have, but for now, since only devs are looking at this, I think this PR is pretty self documenting.
   
   A couple of scenarios I'd like to better understand what tests will run - 
   * #11284 - just java changes in one commit + a docs change in the latest commit (the reverse of #11285 to make sure that it looks at all the changes in the PR and not just the last one)
   * #11285 revert the java changes and push another patch to the PR - should just the doc tests run?
   * docs and web console changes only either in 1 commit or consecutive commits


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org