You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@druid.apache.org by GitBox <gi...@apache.org> on 2018/11/12 15:21:18 UTC

[GitHub] leventov opened a new pull request #6606: Simplify DruidNodeDiscoveryProvider; add DruidNodeDiscovery.Listener.nodeViewInitialized()

leventov opened a new pull request #6606: Simplify DruidNodeDiscoveryProvider; add DruidNodeDiscovery.Listener.nodeViewInitialized()
URL: https://github.com/apache/incubator-druid/pull/6606
 
 
   Recently I spend maybe about 3 hours trying to understand `DruidNodeDiscoveryProvider`. In hopes to make it simpler for other people, I refactored this class.
   
   In order to clarify the logic, I added a separate `DruidNodeDiscovery.Listener.nodeViewInitialized()` method, that brings a secondary benefit: listeners registered with `ServiceDruidNodeDiscovery` could proceed with partially initialized node view if they want, even if some node type didn't report initialization for whatever reason. Although I didn't change any of those listeners yet.
   
   Finally, prohibited and eliminated some suboptimal Java 8 usage patterns.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@druid.apache.org
For additional commands, e-mail: commits-help@druid.apache.org