You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@commons.apache.org by GitBox <gi...@apache.org> on 2020/04/18 04:15:13 UTC
[GitHub] [commons-collections] kinow opened a new pull request #147:
[COLLECTIONS-759]: add newline at end of file,
and convert to unix (LF instead of CRLF) fixing checkstyle
kinow opened a new pull request #147: [COLLECTIONS-759]: add newline at end of file, and convert to unix (LF instead of CRLF) fixing checkstyle
URL: https://github.com/apache/commons-collections/pull/147
As per title, fixing the Travis CI build that is broken at the moment due to checkstyle issues. There are some files that were missing newline at end of file (git).
Added the extra line, but after running `mvn` got the error again. Then noticed it was a CRLF vs. LF issue. Ran the files through `dos2unix`, and finally `mvn` command (default build target, same as in Travis) passed.
Now :crossed_fingers: and wait to see what Travis reports.
Bruno
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] kinow commented on issue #147:
[COLLECTIONS-759]: add newline at end of file,
and convert to unix (LF instead of CRLF) fixing checkstyle
Posted by GitBox <gi...@apache.org>.
kinow commented on issue #147: [COLLECTIONS-759]: add newline at end of file, and convert to unix (LF instead of CRLF) fixing checkstyle
URL: https://github.com/apache/commons-collections/pull/147#issuecomment-615985425
> I'd be better to have .gitattributes to handle such cases...
Hi @michael-o good point, [lang] already has one. I never added one to an existing project. I tried dropping the current commit, and adding the `.gitattributes` from [lang], but running `mvn` checkstyle complained again about CRLF. Are the changes applied only after cloning the repository?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] kinow edited a comment on issue #147:
[COLLECTIONS-759]: add newline at end of file,
and convert to unix (LF instead of CRLF) fixing checkstyle
Posted by GitBox <gi...@apache.org>.
kinow edited a comment on issue #147: [COLLECTIONS-759]: add newline at end of file, and convert to unix (LF instead of CRLF) fixing checkstyle
URL: https://github.com/apache/commons-collections/pull/147#issuecomment-615985425
> I'd be better to have .gitattributes to handle such cases...
Hi @michael-o good point, [lang] already has one. I never added one to an existing project. I tried dropping the current commit, and adding the `.gitattributes` from [lang], but running `mvn` checkstyle complained again about CRLF.
Are the changes applied only after cloning the repository? Or do we actually need both, the commit converting files to unix, and the `.gitattributes` to ensure future commits are automatically converted to LF by git? (I'm guessing the latter)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] kinow edited a comment on issue #147:
[COLLECTIONS-759]: add newline at end of file,
and convert to unix (LF instead of CRLF) fixing checkstyle
Posted by GitBox <gi...@apache.org>.
kinow edited a comment on issue #147: [COLLECTIONS-759]: add newline at end of file, and convert to unix (LF instead of CRLF) fixing checkstyle
URL: https://github.com/apache/commons-collections/pull/147#issuecomment-615985425
> I'd be better to have .gitattributes to handle such cases...
Thanks @michael-o good point, [lang] already has one. I never added one to an existing project. I tried dropping the current commit, and adding the `.gitattributes` from [lang], but running `mvn` checkstyle complained again about CRLF.
Are the changes applied only after cloning the repository? Or do we actually need both, the commit converting files to unix, and the `.gitattributes` to ensure future commits are automatically converted to LF by git? (I'm guessing the latter)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] kinow edited a comment on issue #147:
[COLLECTIONS-759]: add newline at end of file,
and convert to unix (LF instead of CRLF) fixing checkstyle
Posted by GitBox <gi...@apache.org>.
kinow edited a comment on issue #147: [COLLECTIONS-759]: add newline at end of file, and convert to unix (LF instead of CRLF) fixing checkstyle
URL: https://github.com/apache/commons-collections/pull/147#issuecomment-615985425
> I'd be better to have .gitattributes to handle such cases...
Hi @michael-o good point, [lang] already has one. I never added one to an existing project. I tried dropping the current commit, and adding the `.gitattributes` from [lang], but running `mvn` checkstyle complained again about CRLF.
Are the changes applied only after cloning the repository? Or do we actually need both, the commit converting files to unix, and the `.gitattributes` to ensure future commits are automatically converted to LF by git?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
[GitHub] [commons-collections] michael-o commented on issue #147:
[COLLECTIONS-759]: add newline at end of file,
and convert to unix (LF instead of CRLF) fixing checkstyle
Posted by GitBox <gi...@apache.org>.
michael-o commented on issue #147: [COLLECTIONS-759]: add newline at end of file, and convert to unix (LF instead of CRLF) fixing checkstyle
URL: https://github.com/apache/commons-collections/pull/147#issuecomment-615838794
I'd be better to have .gitattributes to handle such cases...
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services