You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "WenyXu (via GitHub)" <gi...@apache.org> on 2023/04/09 16:24:17 UTC
[GitHub] [arrow-rs] WenyXu opened a new pull request, #4041: refactor: refactor from BufReader to BufRead
WenyXu opened a new pull request, #4041:
URL: https://github.com/apache/arrow-rs/pull/4041
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
# Rationale for this change
Enhance API flexibility.
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
Refactor `infer_json_scheam's` reader type from BufReader<Read> to BufRead
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on pull request #4041: refactor: refactor from BufReader to BufRead
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on PR #4041:
URL: https://github.com/apache/arrow-rs/pull/4041#issuecomment-1501178347
Where did you see the clippy error? It was not detected by CI.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] WenyXu commented on pull request #4041: refactor: refactor from BufReader to BufRead
Posted by "WenyXu (via GitHub)" <gi...@apache.org>.
WenyXu commented on PR #4041:
URL: https://github.com/apache/arrow-rs/pull/4041#issuecomment-1501169155
The Clippy seems failed with:
```bash
error: ambiguous glob re-exports
--> arrow/src/compute/kernels/mod.rs:31:13
|
31 | pub use arrow_ord::comparison::*;
| ^^^^^^^^^^^^^^^^^^^^^^^^ the name `contains_utf8` in the value namespace is first re-exported here
32 | pub use arrow_string::like::*;
| --------------------- but the name `contains_utf8` in the value namespace is also re-exported here
|
= note: `-D ambiguous-glob-reexports` implied by `-D warnings`
error: could not compile `arrow` (lib) due to previous error
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on pull request #4041: Use BufRead for JSON Schema Inference
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on PR #4041:
URL: https://github.com/apache/arrow-rs/pull/4041#issuecomment-1501232900
Thank you
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold merged pull request #4041: Use BufRead for JSON Schema Inference
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold merged PR #4041:
URL: https://github.com/apache/arrow-rs/pull/4041
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org