You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@commons.apache.org by br...@apache.org on 2017/06/14 07:57:33 UTC

[10/12] commons-cli git commit: separate testcases

separate testcases


Project: http://git-wip-us.apache.org/repos/asf/commons-cli/repo
Commit: http://git-wip-us.apache.org/repos/asf/commons-cli/commit/f4a28c04
Tree: http://git-wip-us.apache.org/repos/asf/commons-cli/tree/f4a28c04
Diff: http://git-wip-us.apache.org/repos/asf/commons-cli/diff/f4a28c04

Branch: refs/heads/master
Commit: f4a28c0463a414464ebe214a7790fde0b0069e3e
Parents: 4f9c95b
Author: Béla Schaum <sc...@gmail.com>
Authored: Tue Jun 13 13:58:13 2017 +0200
Committer: Béla Schaum <sc...@gmail.com>
Committed: Tue Jun 13 13:58:13 2017 +0200

----------------------------------------------------------------------
 .../commons/cli/PatternOptionBuilderTest.java   | 20 ++++++++++++++------
 1 file changed, 14 insertions(+), 6 deletions(-)
----------------------------------------------------------------------


http://git-wip-us.apache.org/repos/asf/commons-cli/blob/f4a28c04/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java
----------------------------------------------------------------------
diff --git a/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java b/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java
index ff92bc8..3a33eb7 100644
--- a/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java
+++ b/src/test/java/org/apache/commons/cli/PatternOptionBuilderTest.java
@@ -161,15 +161,23 @@ public class PatternOptionBuilderTest
     @Test
     public void testExistingFilePattern() throws Exception
     {
-        final Options options = PatternOptionBuilder.parsePattern("f<g<");
+        final Options options = PatternOptionBuilder.parsePattern("g<");
         final CommandLineParser parser = new PosixParser();
-        final CommandLine line = parser.parse(options, new String[] { "-f", "non-existing.file", "-g", "src/test/resources/existing-readable.file" });
-        
-        assertNull("option f parsed", line.getOptionObject("f"));
+        final CommandLine line = parser.parse(options, new String[] { "-g", "src/test/resources/existing-readable.file" });
+
+        final Object parsedReadableFileStream = line.getOptionObject("g");
 
-        Object parsedReadableFileStream = line.getOptionObject("g");
         assertNotNull("option g not parsed", parsedReadableFileStream);
-        assertEquals("option g not FileInputStream", FileInputStream.class, parsedReadableFileStream.getClass());
+        assertTrue("option g not FileInputStream", parsedReadableFileStream instanceof FileInputStream);
+    }
+
+    @Test
+    public void testExistingFilePatternFileNotExist() throws Exception {
+        final Options options = PatternOptionBuilder.parsePattern("f<");
+        final CommandLineParser parser = new PosixParser();
+        final CommandLine line = parser.parse(options, new String[] { "-f", "non-existing.file" });
+
+        assertNull("option f parsed", line.getOptionObject("f"));
     }
 
     @Test