You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by GitBox <gi...@apache.org> on 2021/01/07 16:16:47 UTC

[GitHub] [httpcomponents-core] desmondyeung opened a new pull request #243: HTTPCORE-657: Add TrafficClass to IOReactorConfig

desmondyeung opened a new pull request #243:
URL: https://github.com/apache/httpcomponents-core/pull/243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] garydgregory commented on pull request #243: HTTPCORE-657: Add TrafficClass to IOReactorConfig

Posted by GitBox <gi...@apache.org>.
garydgregory commented on pull request #243:
URL: https://github.com/apache/httpcomponents-core/pull/243#issuecomment-756244218


   Hi @desmondyeung 
   
   Missing:
   - unit tests
   - Javadoc since tags for new public and protected methods.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] ok2c merged pull request #243: HTTPCORE-657: Add TrafficClass to IOReactorConfig

Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #243:
URL: https://github.com/apache/httpcomponents-core/pull/243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] desmondyeung commented on pull request #243: HTTPCORE-657: Add TrafficClass to IOReactorConfig

Posted by GitBox <gi...@apache.org>.
desmondyeung commented on pull request #243:
URL: https://github.com/apache/httpcomponents-core/pull/243#issuecomment-756464670


   @garydgregory I've added a unit test and the javadoc since tags.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org


[GitHub] [httpcomponents-core] ok2c merged pull request #243: HTTPCORE-657: Add TrafficClass to IOReactorConfig

Posted by GitBox <gi...@apache.org>.
ok2c merged pull request #243:
URL: https://github.com/apache/httpcomponents-core/pull/243


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org