[GitHub] [sling-org-apache-sling-servlets-post] rombert commented on a change in pull request #7: SLING-9896 make exception handling more granular

[GitBox <gi...@apache.org>]

rombert commented on a change in pull request #7:
URL: https://github.com/apache/sling-org-apache-sling-servlets-post/pull/7#discussion_r553433464



##########
File path: src/main/java/org/apache/sling/servlets/post/exceptions/PreconditionViolatedPersistenceException.java
##########
@@ -0,0 +1,48 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.sling.servlets.post.exceptions;
+
+import org.apache.sling.api.resource.PersistenceException;
+
+
+/**
+ *  Indicates that the input does not meet necessary precondition.
+ *  In that case the client should redo the request with a changed input.
+ *
+ */
+
+public class PreconditionViolatedPersistenceException extends PersistenceException {

Review comment:
       My only substantial comment is related to the exceptions. Have you considered making them unchecked, e.g. extend from `SlingException`? The advantage would be that we don't need to tweak signatures if we decide to add new exceptions.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org