[jira] Commented: (QPID-11) Move protocol literals from code to AMQConstant

["Kim van der Riet (JIRA)" <qp...@incubator.apache.org>]

    [ https://issues.apache.org/jira/browse/QPID-11?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#action_12463069 ] 

Kim van der Riet commented on QPID-11:
--------------------------------------

All constants defined as part of the XML are now being generated into a file AmqpConstants.java. Since there is no type associated with these XML constant declarations, each constant comes in three flavours: String, int and double. If the constant contains non-numeric characters, the int and double versions are supressed. If the constant contails a decimal '.', then the int version is suppressed. All are static members of class AmqpConstants.

> Move protocol literals from code to AMQConstant
> -----------------------------------------------
>
>                 Key: QPID-11
>                 URL: https://issues.apache.org/jira/browse/QPID-11
>             Project: Qpid
>          Issue Type: Improvement
>          Components: Java Broker, Java Client
>            Reporter: Martin Ritchie
>            Priority: Trivial
>             Fix For: M2
>
>
> The current Java code has the odd literal value. Such as this from AMQMessage:
>         return _contentHeaderBody.properties instanceof BasicContentHeaderProperties
>                 &&((BasicContentHeaderProperties) _contentHeaderBody.properties).getDeliveryMode() == 2;
> What is deliverymode 2?
> Out of context it makes it hard to understand.  Something like AMQConstants.PersistentDeliveryMode would help reuse and minimise the impact of any protocol changes.

-- 
This message is automatically generated by JIRA.
-
If you think it was sent incorrectly contact one of the administrators: https://issues.apache.org/jira/secure/Administrators.jspa
-
For more information on JIRA, see: http://www.atlassian.com/software/jira