[GitHub] [skywalking] JohnNiang commented on issue #4321: Refactor ConfigInitializer and improve map type config

[GitBox <gi...@apache.org>]

JohnNiang commented on issue #4321: Refactor ConfigInitializer and improve map type config
URL: https://github.com/apache/skywalking/pull/4321#issuecomment-582395028
 
 
   > Could you describe which part you enhanced in this PR? Add some examples and tests to demonstrate it.
   
   If `Config.Agent` contains field as follow:
   
   ```java
   public class Config {
   
       public static class Agent {
           // The int, long, float, double, list and enum type were not interpreted before
           public static Map<String, Integer> map;
       }
   }
   ```
   
   And if `agent.conf` like this:
   
   ```conf
   skywalking.agent.map[test1] = 1
   skywalking.agent.map[test2] = 2
   ```
   
   This PR refactor some codes  lets the above config work well.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services