You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/08/05 18:11:19 UTC

[GitHub] [skywalking-python] sonatype-lift[bot] commented on a change in pull request #145: Cleaned up Tags

sonatype-lift[bot] commented on a change in pull request #145:
URL: https://github.com/apache/skywalking-python/pull/145#discussion_r683681543



##########
File path: skywalking/trace/span.py
##########
@@ -57,7 +58,7 @@ def __init__(
         self.layer = layer or Layer.Unknown  # type: Layer
         self.inherit = Component.Unknown  # type: Component
 
-        self.tags = []  # type: List[Tag]
+        self.tags = defaultdict(list)  # type: Dict[str, Union(Tag, List[Tag])]

Review comment:
       *Invalid type:*  Expression `Dict[(str, Union(skywalking.trace.tags.Tag, typing.List[skywalking.trace.tags.Tag]))]` is not a valid type.
   (at-me [in a reply](https://help.sonatype.com/lift) with `help` or `ignore`)




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org