You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@airflow.apache.org by "hussein-awala (via GitHub)" <gi...@apache.org> on 2023/04/22 22:29:55 UTC
[GitHub] [airflow] hussein-awala opened a new pull request, #30819: Fix XCom deserialization when it contains nonprimitive values
hussein-awala opened a new pull request, #30819:
URL: https://github.com/apache/airflow/pull/30819
closes: #30797
related: #30798
Fix XCom deserialization when the serialized XCom contains nonprimitive values. The problem is that the deserialization is done by recursion on the different depth, and when we reach the last depth, we raise an exception instead of returning the deserialized value.
We don't need to check the validity of the data because they are serialized by Airflow. The deserialize method should revert the serialized data without any issue.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk merged pull request #30819: Fix XCom deserialization when it contains nonprimitive values
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk merged PR #30819:
URL: https://github.com/apache/airflow/pull/30819
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] bolkedebruin commented on pull request #30819: Fix XCom deserialization when it contains nonprimitive values
Posted by "bolkedebruin (via GitHub)" <gi...@apache.org>.
bolkedebruin commented on PR #30819:
URL: https://github.com/apache/airflow/pull/30819#issuecomment-1519063840
checking why the testing code was added to `tests/utils/test_json.py` rather than serializers? And is this tied to pandas or can a different test case be written so that it doesnt rely on that?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [airflow] potiuk commented on pull request #30819: Fix XCom deserialization when it contains nonprimitive values
Posted by "potiuk (via GitHub)" <gi...@apache.org>.
potiuk commented on PR #30819:
URL: https://github.com/apache/airflow/pull/30819#issuecomment-1519013106
Others? That seems like a fix to the last blocker for 2.6.0 :)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@airflow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org