You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "slow-J (via GitHub)" <gi...@apache.org> on 2023/12/12 11:10:51 UTC

[I] [Minor] ForUtil generated file does not conform to spotless [lucene]

slow-J opened a new issue, #12923:
URL: https://github.com/apache/lucene/issues/12923

   ### Description
   
   ForUtil generated from the gradle task is out of sync with spotless, forcing a run of ./gradlew tidy.
   This is not a large issue, but the code should be consistent in my opinion.
   
   Repro:
   
   ```
   rm lucene/core/src/java/org/apache/lucene/codecs/lucene99/ForUtil.java
   ./gradlew generateForUtilInternal
   ```
   ```
   git diff
   ```
   [ForUtil_git_diff.patch](https://github.com/apache/lucene/files/13647284/ForUtil_git_diff.patch)
   
   ```
   ./gradlew tidy && git status
   ```
   ```
   nothing to commit, working tree clean
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] [Minor] ForUtil generated file does not conform to spotless [lucene]

Posted by "slow-J (via GitHub)" <gi...@apache.org>.
slow-J commented on issue #12923:
URL: https://github.com/apache/lucene/issues/12923#issuecomment-1851934034

   Ah ok, answering myself: running the command: `./gradlew generateForUtil` will apply spotless....


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] [Minor] Regeneration investigation [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on issue #12923:
URL: https://github.com/apache/lucene/issues/12923#issuecomment-1852482593

   See https://github.com/apache/lucene/pull/12924 - I think it's something that fixes your problem. Also, take a look at:
   https://github.com/apache/lucene/blob/main/help/regeneration.txt unless you have already - the internal tasks are not supposed to be called directly.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] [Minor] Regeneration investigation [lucene]

Posted by "slow-J (via GitHub)" <gi...@apache.org>.
slow-J commented on issue #12923:
URL: https://github.com/apache/lucene/issues/12923#issuecomment-1852471268

   > I think it's because of changes in the fst code. So seems legitimate.
   
   Thanks @dweiss, does this mean that we should regenerate these 2 `TokenInfoDictionary`? 
   Or does it simply mean that is being getting regenerated (needlessly) on my side due to the recent change?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] [Minor] ForUtil generated file does not conform to spotless [lucene]

Posted by "slow-J (via GitHub)" <gi...@apache.org>.
slow-J commented on issue #12923:
URL: https://github.com/apache/lucene/issues/12923#issuecomment-1851936071

   An actual valid nuance related to regeneration:
   running `./gradlew regenerate`
   will modify 
   ```
   	modified:   lucene/analysis/kuromoji/src/resources/org/apache/lucene/analysis/ja/dict/TokenInfoDictionary$fst.dat
   	modified:   lucene/analysis/nori/src/resources/org/apache/lucene/analysis/ko/dict/TokenInfoDictionary$fst.dat
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] [Minor] Regeneration investigation [lucene]

Posted by "slow-J (via GitHub)" <gi...@apache.org>.
slow-J commented on issue #12923:
URL: https://github.com/apache/lucene/issues/12923#issuecomment-1852542026

   > See #12924 - I think it's something that fixes your problem. Also, take a look at:
   > https://github.com/apache/lucene/blob/main/help/regeneration.txt unless you have already - the internal tasks are not supposed to be called directly.
   
   Ah the fix is already out, thanks for the link!
   And yes I realised that I was doing something wrong called the internal task. Thanks for the help.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] [Minor] Regeneration investigation [lucene]

Posted by "slow-J (via GitHub)" <gi...@apache.org>.
slow-J closed issue #12923: [Minor] Regeneration investigation
URL: https://github.com/apache/lucene/issues/12923


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org


Re: [I] [Minor] Regeneration investigation [lucene]

Posted by "dweiss (via GitHub)" <gi...@apache.org>.
dweiss commented on issue #12923:
URL: https://github.com/apache/lucene/issues/12923#issuecomment-1852401144

   I think it's because of changes in the fst code. So seems legitimate.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org